-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitea fails to start with git 2.29.0.rc0.261.g7178c9af9c #13067
Gitea fails to start with git 2.29.0.rc0.261.g7178c9af9c #13067
Comments
Also, we have already seen something similar in #12731 before. |
I tryed to enhance the regex again, didnt found a good soultion for now :( |
I'm trying something, too. |
Please ignore that PR from me for this issue. Some autocomplete feature ran amok and linked the wrong issue. Sorry for the confusion. :-| |
... but now that I'm here, I might as well look into the issue. I did some tweaking of the RegEx myself and actually quickly found one that worked. SemVer demands the following:
In prose: the version core, in the case of our offending git version What we have instead is a In conclusion, as long as gitea uses hashicorp/go-version with its demand for correct Semantic Versioning, I don't see how it can support git version
|
@eneuschild go-version has two functions ... one who explicit only parse SemVers and one who try to parse Versions at all (second one is used and should know what to do with the string ...) PS: until hashicorp do not act at all, can you send pulls to my fork & upstream? |
whoa, this was fast! |
Or we should advise users not to use pre-release |
On it. :) |
ok first pull got merged, waiting for second one ... will release new version after this :) |
-> #13169 |
works like a charm, thanks! @6543 @eneuschild 🎉 |
Gitea version 1.13.0+dev-743-ge0b772780 built with GNU Make 4.3, go1.15.2 : bindata, sqlite, sqlite_unlock_notify
2.29.0.rc0.261.g7178c9af9c
Description
Gitea fails to start after a recent update, I suppose the reason might be an error in parsing of the git version string, as it recently moved on to an rc for
2.29.0
(see git version above) and changed the format a little - note the addedrc0
.A rollback to an earlier version of git (
git version 2.28.0.788.g542b3c2573
- which has been working just fine before) as well as to a previous release version (such as2.28.0
) solves this for me momentarily and Gitea starts without issues.The text was updated successfully, but these errors were encountered: