Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] SVG Diff #14329

Closed
kdumontnu opened this issue Jan 13, 2021 · 5 comments · Fixed by #14867
Closed

[Feature Request] SVG Diff #14329

kdumontnu opened this issue Jan 13, 2021 · 5 comments · Fixed by #14867
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@kdumontnu
Copy link
Contributor

Now that we support svg rendering we should consider adding support for rendered svg diff.

This shows the basic functionality in GitHub.

GH Demo

See live GitHub example (note: GitHub actually seems to have a bug in swipe mode when the SVG size has changed it shows both on tope of one-another)

Personally, I find the the onion skin mode to be the least helpful, but the other two modes are quite useful.

Request:

  • Like GitHub, we should render the svg diff in PRs and commit diff view
  • Like GitHub, we should have a toggle button to switch between code and render mode
  • Unlike GitHub, the toggle button should be "sticky" between sessions/page-views, so that a user navigating between PR tabs doesn't have to repeatedly toggle the button.
  • Unlike GitHub, the default toggle state should be configurable by either repository, user, or gitea instance
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jan 14, 2021
@lunny
Copy link
Member

lunny commented Jan 14, 2021

We have already Image Diff, so I think this should not be very difficult.

@6543
Copy link
Member

6543 commented Feb 11, 2021

could it be closed by #14450 ?

@kdumontnu
Copy link
Contributor Author

could it be closed by #14450 ?

Yep!

@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 12, 2021

No. #14450 is just a nicer image diff but without SVG support. After #14450 is merged I will create a new PR with support for SVG images (~80% done).

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 3, 2021

#14867 implements this request.

@lafriks lafriks added this to the 1.15.0 milestone Jun 5, 2021
@lafriks lafriks added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jun 5, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants