Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 page not rendered #14473

Closed
6543 opened this issue Jan 26, 2021 · 0 comments · Fixed by #14474
Closed

500 page not rendered #14473

6543 opened this issue Jan 26, 2021 · 0 comments · Fixed by #14474
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Milestone

Comments

@6543
Copy link
Member

6543 commented Jan 26, 2021

Gitea version: 1.14.0+dev-610-gafbddf1f0

If you apply this patch to test a panic:

diff --git a/routers/user/profile.go b/routers/user/profile.go
index e19407baa..99c17479b 100644
--- a/routers/user/profile.go
+++ b/routers/user/profile.go
@@ -53,6 +53,10 @@ func Profile(ctx *context.Context) {
                return
        }
 
+       if uname != "" {
+               panic("Let's panic")
+       }
+
        isShowKeys := false
        if strings.HasSuffix(uname, ".keys") {
                isShowKeys = true

It return a plain text with the stack-trace

@6543 6543 added the type/bug label Jan 26, 2021
@6543 6543 added this to the 1.14.0 milestone Jan 26, 2021
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 26, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants