Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary email cannot be activated when ‘RegisterEmailConfirm’ is enabled #16370

Closed
3 of 6 tasks
Meano opened this issue Jul 8, 2021 · 0 comments
Closed
3 of 6 tasks
Labels
Milestone

Comments

@Meano
Copy link
Contributor

Meano commented Jul 8, 2021

  • Gitea version (or commit ref): 1.15.0+dev-549-gbc6f060b8

  • Git version: 2.30.2

  • Operating system:

    Ubuntu 21.04 & Windows 10
    Both the official version and the version compiled by myself have been tested.
    I am running gitea from systemd(247.3-3ubuntu3.1) or WinSW(3.0.0).

  • Database (use [x]):

    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:

    • Yes (/user/settings/account /admin/emails)
    • No
  • Log gist:

It fired an error when a new user who signed up without primary mail activated click the Send Activation button.

Send activation: email not set for activation

Description

  1. When RegisterEmailConfirm is enabled, the primary email should be activated together with the user account. Otherwise, the primary email can not be activated for the Send Activation not work, and the admin can not activate the user email either.
  2. There is some invalid params in email template since Localize Email Templates #16200. Like %!(EXTRA string=xxx, string=Gitea: Git with a cup of tea)
  3. I guess the i18n: mail.activate_account.test_x might be a typo, maybe mail.activate_account.text_x?

I have fixed the errors above. Could I create a PR?
main...Meano:develop

Screenshots

SendActionNot Working
AdminActivateNotWorking

InvalidParams

@lafriks lafriks added this to the 1.15.0 milestone Jul 9, 2021
@6543 6543 closed this as completed Jul 13, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants