Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gitea 1.15.0 - service doesn't start WinSrv 2008R2 #16784

Closed
4 tasks
sasa00 opened this issue Aug 23, 2021 · 4 comments
Closed
4 tasks

Upgrade to Gitea 1.15.0 - service doesn't start WinSrv 2008R2 #16784

sasa00 opened this issue Aug 23, 2021 · 4 comments
Labels
issue/duplicate The issue has already been reported.

Comments

@sasa00
Copy link

sasa00 commented Aug 23, 2021

  • Gitea version (or commit ref): 1.15.0
  • Git version: version 2.25.1.windows.1
  • Operating system: WinSrv 2008 R2 with ready built gitea-1.15.0-windows-4.0-amd64.exe
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • [x ] SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • [ x] No
  • Log gist:
    log.txt

Hi,

I tried updating from v1.14.6 to 1.15.0. After restarting the service I get an error 1067 from Services:
image

In the log files I could not see any error. Last entry finishes with:
[2 Cron: Check all repository statistics has finished 1629713364] - 1ms

I already switched log to "DEBUG".

KR,
Sascha

@noerw
Copy link
Member

noerw commented Aug 23, 2021

Did you follow the migration notes described in https://blog.gitea.io/2021/08/gitea-1.15.0-is-released?

..this looks quite similar to #16779, as the log does not contain any errors and fails to start after the update.

@zeripath
Copy link
Contributor

Can you try just starting gitea from a command line and seeing if something is emitted there.

@sasa00
Copy link
Author

sasa00 commented Aug 23, 2021

Hello,

in the meantime I figured out what was wrong. I had a "install-service"- script with "\" as folder dividers for the app.ini. This does not seem to work anymore. I changed my add service script
from:
sc.exe create gitea start= auto binpath= "\"c:\gitea\gitea.exe\" web --config \"c:\gitea\custom\conf\app.ini\""
to:
sc.exe create gitea start= auto binpath= "\"c:\gitea\gitea.exe\" web --config \"c:/gitea/custom/conf/app.ini/""

and re-installed the service (remove & add again). This made my gitea server start again. Additionally I had an error in an template where I exchanged the gitea logo with our company logo and the new version did not find the "{{StaticUrlPrefix}}" variable anymore. I just deleted the template and now gitea seems to work again.

Nevertheless, thanks you for the fast response;

Sascha

@sasa00 sasa00 closed this as completed Aug 23, 2021
@zeripath
Copy link
Contributor

Additionally I had an error in an template where I exchanged the gitea logo with our company logo and the new version did not find the "{{StaticUrlPrefix}}" variable anymore. I just deleted the template and now gitea seems to work again.

this is probably the root cause for the death. It causes an unguarded panic in a goroutine when the templates get compiled and kills the server.

The panic would only get emitted on the console as it's completely unguarded and so its logging is made by the go runtime as it kills program - not our logging suite.

@zeripath zeripath added the issue/duplicate The issue has already been reported. label Sep 11, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Development

No branches or pull requests

3 participants