Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications write-APIs should return the modified notifications #16797

Closed
noerw opened this issue Aug 24, 2021 · 0 comments · Fixed by #17064
Closed

notifications write-APIs should return the modified notifications #16797

noerw opened this issue Aug 24, 2021 · 0 comments · Fixed by #17064
Labels
modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality

Comments

@noerw
Copy link
Member

noerw commented Aug 24, 2021

  • Gitea version (or commit ref): 1.16.0+dev-109-gd17f555fe

Description

The following endpoints return an empty response, whereas it would be useful to get the notifications back that were affected by the request:

  • PUT /api/v1/notifications
  • PUT /api/v1/repos/:owner/:repo/notifications
  • PATCH /api/v1/notifications/threads/:id

also, while we're at it:
The NotificationSubject struct contains URL and LatestCommentURL fields, but a fieldf WebURL and LatestCommentWebURL would be quite handy

@noerw noerw added type/enhancement An improvement of existing functionality modifies/api This PR adds API routes or modifies them labels Aug 24, 2021
@noerw noerw changed the title notifications with write access should return the modified notifications notifications write-APIs should return the modified notifications Aug 24, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant