-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html comments are shown in PR and issue descriptions #19195
Comments
It seems |
As discussed in the chat:
|
maybe the |
I think this is fixed in a later version |
Should be a quick fix in this case. |
When can i expect a fixed gitea version? If it needs some days i would create a small jquery script on page load to fix it temporary |
Don't know, one of the maintainers could give us a rough timeline. |
Just ask if it's worth to create the quickfix 🙃 |
Can confirm that updating goldmark fixes the issue:
So you could build it with the fixed version from the |
OK, thanks. Will do a jQuery quickfix for now. It's easier, as i already have a custom js file embedded. 😉 $('.task-list-item').contents().each((i, e) => {
if (e.nodeName === '#text') {
e.textContent = e.textContent.replaceAll(/\x3C!--.*?-->/g, '')
}
}) |
Description
Since v1.16.5 Html comments are shown in PR and issue descriptions, they should be hidden as before.
Reproducer: https://try.gitea.io/viceice/test/issues/1
Gitea Version
1.16.5
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Git Version
No response
Operating System
No response
How are you running Gitea?
Official helm chart with slim image
Database
PostgreSQL
The text was updated successfully, but these errors were encountered: