Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An API call to sync a non-mirror repository should fail #19299

Closed
petergardfjall opened this issue Apr 1, 2022 · 2 comments
Closed

An API call to sync a non-mirror repository should fail #19299

petergardfjall opened this issue Apr 1, 2022 · 2 comments
Labels
type/bug

Comments

@petergardfjall
Copy link
Contributor

Description

An attempt to mirror-sync (/api/v1/repos/<user>/<repo>/mirror-sync) a repository that isn't a mirror should probably fail with a 400 (Bad Request).

Currently Gitea happily answers 200 (OK) which is an surprising result from a client perspective.

Gitea Version

tip of main

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.25.1

Operating System

Ubuntu 20.04

How are you running Gitea?

Local binary.

Database

PostgreSQL
@petergardfjall petergardfjall mentioned this issue Apr 1, 2022
Merged
@petergardfjall
Copy link
Contributor Author

Attempt to fix in: #19300

@petergardfjall
Copy link
Contributor Author

Fix merged: #19300

@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petergardfjall