Some commits are shown as ... in file list with js error: JavaScript error: Uncaught TypeError: Cannot read properties of undefined (reading 'replaceWith')

[Fogapod]

Description

https://gitea.com/marktsai0316/linux/src/branch/master/scripts
https://gitea.com/marktsai0316/linux/src/branch/master/scripts/clang-tools
https://gitea.com/marktsai0316/linux/src/branch/master/scripts/atomic

Error from ui: JavaScript error: Uncaught TypeError: Cannot read properties of undefined (reading 'replaceWith') (https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873 @ 83:2368). Open browser console to see more details.
From console:

Uncaught TypeError: Cannot read properties of undefined (reading 'replaceWith')
    at HTMLTableRowElement.<anonymous> (index.js?v=5b550aecacf32806c61a3f6e9820c873:83:2368)
    at Function.each (index.js?v=5b550aecacf32806c61a3f6e9820c873:1:5483)
    at s.fn.init.each (index.js?v=5b550aecacf32806c61a3f6e9820c873:1:3942)
    at Object.success (index.js?v=5b550aecacf32806c61a3f6e9820c873:83:2229)
    at Ce (index.js?v=5b550aecacf32806c61a3f6e9820c873:1:32645)
    at Object.fireWith [as resolveWith] (index.js?v=5b550aecacf32806c61a3f6e9820c873:1:33444)
    at Xi (index.js?v=5b550aecacf32806c61a3f6e9820c873:4:6109)
    at XMLHttpRequest.<anonymous> (index.js?v=5b550aecacf32806c61a3f6e9820c873:4:8596)

When this happens, some files dont show commit message/date:

I am not sure how to reproduce this reliably yet. It just happens randomly with random files when going through folders

Error goes away after a few page refreshes. I noticed that it happens more frequently with small browser window

Screenshots

Gitea Version

1.17.0+dev-711-g1fef9a2d6

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Artix Linux

Browser Version

Chromium based 100+

[lunny]

Cannot reproduce it in macOS 12.4 with Chrome 97.0

[Fogapod]

I just reproduced this with librewolf 101.0.1 (firefox based), so this doesn't seem browser related.

I suggest going through different folders because it seems like this error goes away for some time after you open these folders. Probably caching related somehow.

EDIT: just noticed that there is a different error now but the result is similar. Error text: JavaScript error: TypeError: e[r(...).attr(...)] is undefined (https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873 @ 83:2344). Open browser console to see more details.

Console:

Uncaught TypeError: e[r(...).attr(...)] is undefined
    mb https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:83
    each https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:1
    each https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:1
    mb https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:83
    Ce https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:1
    fireWith https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:1
    Xi https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:4
    u https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:4
[index.js:83:2344](https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873)
    mb https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:83
    each https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:1
    each https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:1
    mb https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:83
    Ce https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:1
    fireWith https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:1
    Xi https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:4
    u https://gitea.com/assets/js/index.js?v=5b550aecacf32806c61a3f6e9820c873:4

[wxiaoguang]

index.js: {r("table#repo-files-table .commit-list").replaceWith(l);return}e[r(l).attr("data-entryname")].replaceWith(l)})

Crashed here:

gitea/web_src/js/features/repo-commit.js

Line 48 in a036507

entryMap[$(row).attr('data-entryname')].replaceWith(row);

[wxiaoguang]

A quick patch: #19996

• Fix a JS error in initRepoCommitLastCommitLoader's entryMap #19996

I do not know how it happens at the moment, the logic seems complex here. 😂

[wxiaoguang]

@Fogapod that's very strange that I still have difficult to reproduce the problem. So here is a quick patch.

Could you find more clues about how to trigger the error? It seems that the returned content is the key. Could you share the returned lastcommit response when error occurs? Thank you very much.

[Fogapod]

What do you mean by lastcommit?
I have https://gitea.com/marktsai0316/linux/src/branch/master/drivers opened right now and more than half of files are shown as ....
These are all requests i have:

[wxiaoguang]

Hmm .... I think I have some clues about the problem .....

[Fogapod]

In case this is somehow useful: red box is properly displayed commit, blue is .... Css classes are different for them. I don't know what this might mean though:

[wxiaoguang]

OK, everything clear. Will update the PR soon.

The problem is that there are unrecognized tr rows in response, and the JS code didn't handle it correctly.