Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary horizontal scrollbar arrows on Firefox #20139

Closed
jpraet opened this issue Jun 26, 2022 · 9 comments · Fixed by #20142
Closed

Unnecessary horizontal scrollbar arrows on Firefox #20139

jpraet opened this issue Jun 26, 2022 · 9 comments · Fixed by #20142
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@jpraet
Copy link
Member

jpraet commented Jun 26, 2022

Description

On Firefox, some pages show unnecessary horizontal scrollbar arrows. This does not happen on Chrome.

Screenshots

Firefox:

image

image

Chrome:

image

image

Gitea Version

1.18.0+dev-37-g711cbcce8

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows 10 21H2

Browser Version

101.0.1
@jpraet jpraet added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 26, 2022
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 26, 2022 •
edited
Loading

I also use Firefox a lot , can not reproduce it at the moment .... do you have any clue?

Mine is Firefox 101.0.1 (64-bit) macOS

image

image

@jpraet
Copy link
Member Author

jpraet commented Jun 26, 2022

Etzelia also reported it on discord #general some time ago. Maybe different Firefox version, or OS?

@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 26, 2022

I noticed that problem too. Firefox 101.0.1 on Windows

@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 26, 2022

Looked into it and it's caused by overflow-x: scroll; from #19945 @Gusted

@Gusted
Copy link
Contributor

Gusted commented Jun 26, 2022

I'm on Linux, no issue. It could be on windows that when overflow-x: scroll is specified it will unconditionally show a scrollbar? But that's quite stupid. Could you try adjusting it to overflow-x: auto;? That might help, as that should be more "dynamic".

@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 26, 2022 •
edited
Loading

Yep, works with auto.

Edit: Tested it with a small screensize too and the scrollbar works as intended.

@delvh
Copy link
Member

delvh commented Jun 26, 2022

There is a display difference between Firefox on Linux and Windows?
That would at least explain why both @Gusted and me did not notice any problem with it...

@Gusted
Copy link
Contributor

Gusted commented Jun 26, 2022

There is a display difference between Firefox on Linux and Windows?

Yeah browsers tend to do that(historical reasons). Ah well, luckily that doesn't beat me and auto works. I will get up a patch.

Gusted pushed a commit to Gusted/gitea that referenced this issue Jun 26, 2022
Show scrollbar when necessary
f46a0af 
- Firefox on Windows will unconditionally show scrollbars when you
specify `overflow: scroll`. This is bad behavior, as you don't always
need the scrollbar. Changing the scroll value to auto fixes this issue
and only shows the scrollbar when necessary.
- Resolves go-gitea#20139
@Gusted Gusted mentioned this issue Jun 26, 2022
Merged
Gusted pushed a commit to Gusted/gitea that referenced this issue Jun 26, 2022
Show scrollbar when necessary (go-gitea#20142)
eba3985 
- Backport go-gitea#20142
  - Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary.
  - Resolves go-gitea#20139
@Gusted Gusted mentioned this issue Jun 26, 2022
Merged
@Gusted
Copy link
Contributor

Gusted commented Jun 26, 2022

#20142 and backport lives at #20143

lunny pushed a commit that referenced this issue Jun 27, 2022
Show scrollbar when necessary (#20142) (#20143)
0dab138 
- Backport #20142
  - Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary.
  - Resolves #20139
lunny added a commit that referenced this issue Jun 27, 2022
@lunny
Show scrollbar when necessary (#20142)
5371964 
- Firefox on Windows will unconditionally show scrollbars when you
specify `overflow: scroll`. This is bad behavior, as you don't always
need the scrollbar. Changing the scroll value to auto fixes this issue
and only shows the scrollbar when necessary.
- Resolves #20139

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 10, 2022
@lunny
Show scrollbar when necessary (go-gitea#20142)
a533b45 
- Firefox on Windows will unconditionally show scrollbars when you
specify `overflow: scroll`. This is bad behavior, as you don't always
need the scrollbar. Changing the scroll value to auto fixes this issue
and only shows the scrollbar when necessary.
- Resolves go-gitea#20139

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show scrollbar when necessary Gusted/gitea
5 participants
@KN4CK3R @wxiaoguang @jpraet @Gusted @delvh