You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I came across this file and would like this to be discussed: as far as I can tell at the frontend the code seems not to be necessary, am I wrong, what about the backend-side of this?
there is clone_script.tmpl, but as I already mentioned all works fine without editing this and I also tested the case of an empty clone_script and it doesn't break the functionality or the generated links.
and the file has this comments:
// synchronously set clone button states and urls here to avoid flickering
// on page load. initRepoCloneLink calls this when proto changes.
// this applies the protocol-dependant clone url to all elements with the
// js-clone-url and js-clone-url-vsc classes.
// TODO: This localStorage setting should be moved to backend user config
// so it's available during rendering, then this inline script can be removed.
to me it seems that it can be removed, but I guess this is another issue and should be discussed seperately?!
I wanted to add a button to clone a repo in VSCodium like it is already possible to do for VSCode. And this script inside clone_script.tmpl handles or handled the link behind the button that includes a custom handle like vscode:// or vscodium://
I came across this file and would like this to be discussed: as far as I can tell at the frontend the code seems not to be necessary, am I wrong, what about the backend-side of this?
to me it seems that it can be removed, but I guess this is another issue and should be discussed seperately?!
Originally posted by @redwerkz in #21123 (comment)
The text was updated successfully, but these errors were encountered: