Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set DISABLE_DOWNLOAD_SOURCE_ARCHIVES to true, but still can download from UI #22849

Closed
schmurtzm opened this issue Feb 10, 2023 · 2 comments
Closed
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@schmurtzm
Copy link

schmurtzm commented Feb 10, 2023

Description

After set DISABLE_DOWNLOAD_SOURCE_ARCHIVES = true in app.ini file, and restart gitea. But it's still there.
Same issue : #20685 , I saw the fix #20701 but still the same problem on Gitea 1.8.3 (Windows 64 version : gitea-1.18.3-gogit-windows-4.0-amd64.exe )

It's annoying because on big repo this functionality try to zip all the repo which can break server performances.

Screenshots

image

Gitea Version

1.8.3

Can you reproduce the bug on the Gitea demo site?

No

Operating System

Windows

Browser Version

FF 109.0.1

@schmurtzm schmurtzm added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 10, 2023
@wolfogre
Copy link
Member

wolfogre commented Feb 10, 2023

However, if you click the button, you will see there's no download link:

image

I know it's confusing, so in the next version (probably v1.19.0), it will look like:

image

Please feel free to reopen this issue if there are any other questions.

@schmurtzm
Copy link
Author

Oh indeed ! I was afraid to click on it because last time it has almost killed my instance during the zip process due to high demanding ressources.
Thank you.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

No branches or pull requests

2 participants