Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository homepage readme cannot render images of the repository. #23151

Closed
hiifong opened this issue Feb 25, 2023 · 1 comment · Fixed by #23152
Closed

Repository homepage readme cannot render images of the repository. #23151

hiifong opened this issue Feb 25, 2023 · 1 comment · Fixed by #23152
Labels
type/bug

Comments

@hiifong
Copy link
Member

hiifong commented Feb 25, 2023

Description

No response

Gitea Version

v1.19+

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image
image

Git Version

No response

Operating System

No response

How are you running Gitea?

./gitea web

Database

None
@yp05327
Copy link
Member

yp05327 commented Feb 25, 2023

Branch Name is missing in the link.

The Wrong One:
https://gitea.com/hiifong/AuthenticatorPro/media/branch/doc/Rebranding/Wordmark.png
The Right One:
https://gitea.com/hiifong/AuthenticatorPro/media/branch/master/doc/Rebranding/Wordmark.png

@yp05327 yp05327 mentioned this issue Feb 25, 2023
Merged
lunny pushed a commit that referenced this issue Mar 3, 2023
@yp05327 @wolfogre
@jolheiser @silverwind
Use correct README link to render the README (#23152)
699f202 
`renderReadmeFile` needs `readmeTreelink` as parameter but gets
`treeLink`.
The values of them look like as following:
`treeLink`:  `/{OwnerName}/{RepoName}/src/branch/{BranchName}`
`readmeTreelink`:
`/{OwnerName}/{RepoName}/src/branch/{BranchName}/{ReadmeFileName}`

`path.Dir` in

https://github.com/go-gitea/gitea/blob/8540fc45b11eff9a73753ca139f8ea5c38509bf5/routers/web/repo/view.go#L316
should convert `readmeTreelink` into
`/{OwnerName}/{RepoName}/src/branch/{BranchName}` instead of the current
`/{OwnerName}/{RepoName}/src/branch`.

Fixes #23151

---------

Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot mentioned this issue Mar 3, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 3, 2023
@yp05327 @wolfogre
@jolheiser @silverwind @GiteaBot
Use correct README link to render the README (go-gitea#23152)
dbee9d3 
`renderReadmeFile` needs `readmeTreelink` as parameter but gets
`treeLink`.
The values of them look like as following:
`treeLink`:  `/{OwnerName}/{RepoName}/src/branch/{BranchName}`
`readmeTreelink`:
`/{OwnerName}/{RepoName}/src/branch/{BranchName}/{ReadmeFileName}`

`path.Dir` in

https://github.com/go-gitea/gitea/blob/8540fc45b11eff9a73753ca139f8ea5c38509bf5/routers/web/repo/view.go#L316
should convert `readmeTreelink` into
`/{OwnerName}/{RepoName}/src/branch/{BranchName}` instead of the current
`/{OwnerName}/{RepoName}/src/branch`.

Fixes go-gitea#23151

---------

Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
techknowlogick pushed a commit that referenced this issue Mar 4, 2023
@GiteaBot @yp05327
@wolfogre @jolheiser @silverwind
Use correct README link to render the README (#23152) (#23264)
1322cd7 
Backport #23152

`renderReadmeFile` needs `readmeTreelink` as parameter but gets
`treeLink`.
The values of them look like as following:
`treeLink`:  `/{OwnerName}/{RepoName}/src/branch/{BranchName}`
`readmeTreelink`:
`/{OwnerName}/{RepoName}/src/branch/{BranchName}/{ReadmeFileName}`

`path.Dir` in

https://github.com/go-gitea/gitea/blob/8540fc45b11eff9a73753ca139f8ea5c38509bf5/routers/web/repo/view.go#L316
should convert `readmeTreelink` into
`/{OwnerName}/{RepoName}/src/branch/{BranchName}` instead of the current
`/{OwnerName}/{RepoName}/src/branch`.

Fixes #23151

Co-authored-by: yp05327 <576951401@qq.com>
Co-authored-by: Jason Song <i@wolfogre.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct README link to render the README yp05327/gitea
2 participants
@yp05327 @hiifong