Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions not triggered on push events for mirrored repos #24926

Closed
dboreham opened this issue May 25, 2023 · 1 comment
Closed

Actions not triggered on push events for mirrored repos #24926

dboreham opened this issue May 25, 2023 · 1 comment
Labels

Comments

@dboreham
Copy link

Description

This is a regression since around 1.19.2.

Previously Actions tasks would be run according to their event and branch rules on mirrored commits.
But in the current code (1.19.2,3 and in today's main branch) that doesn't happen. Tasks are never run.

Some debugging reveals that this is because the workflow filtering code in matchPushEvent() checks the supplied refName to see if it is a branch in this function. That check fails in the mirrored code path because refName lacks the necessary prefix. That is, it ends up being "main" not "refs/heads/main".

I tested a somewhat blind fix in that it works but I don't understand this part of the code well enough to know if it's the right fix.

Gitea Version

1.19.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

In docker-compose, using this setup: https://github.com/cerc-io/hosting/tree/main/gitea

Database

PostgreSQL

@dboreham
Copy link
Author

Closing as a dup of #24824

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant