Changelog for 1.21 missing CI approval notice

[WeirdPtr]

Description

When upgrading from 1.20.5 to 1.21.2 the CI pipeline status checks were ignored in PRs.

I checked the release notes before updating the instance here, however nothing mentioned this change.

After investigating the database i found out, that when a repo had status checks enabled but no custom pattern was supplied it skipped the check.

When i updated the field status_check_contexts to [*] status checks worked again.

Query used to find "broken" branch status check entries:

select
    protected_branch.status_check_contexts,
    repository.id
from repository
     join protected_branch
       on protected_branch.repo_id = repository.id
where protected_branch.enable_status_check
      and ( protected_branch.status_check_contexts is null
            or protected_branch.status_check_contexts = 'null' )

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.20.1

Operating System

Debian

How are you running Gitea?

Docker Compose
Image: gitea/gitea:1.21

Database

PostgreSQL

[kstruessmann]

Behaviour has changed as a result of this PR: Support for status check pattern (#24633)

[Zettat123]

The feature introduced in #24633 should be compatible with status_check_contexts. However, if one or more of status_check_contexts is not a legal glob expressions, glob.Compile will fail and the contexts cannot match.

gitea/routers/web/repo/pull.go

Lines 653 to 663 in 21229ed

	if pb != nil && pb.EnableStatusCheck {
	ctx.Data["is_context_required"] = func(context string) bool {
	for _, c := range pb.StatusCheckContexts {
	if gp, err := glob.Compile(c); err == nil && gp.Match(context) {
	return true
	}
	}
	return false
	}
	ctx.Data["RequiredStatusCheckState"] = pull_service.MergeRequiredContextsCommitStatus(commitStatuses, pb.StatusCheckContexts)
	}

I'll try to make a PR to fix it