Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect notification message box in dashboard #30566

Closed
yp05327 opened this issue Apr 18, 2024 · 5 comments · Fixed by #30572
Closed

Incorrect notification message box in dashboard #30566

yp05327 opened this issue Apr 18, 2024 · 5 comments · Fixed by #30572
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented Apr 18, 2024

Description

image

Gitea Version

1.23.0+dev-158-g2da1dcfc21

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None
@yp05327 yp05327 added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 18, 2024
@silverwind
Copy link
Member

Regression from #30214.

@silverwind silverwind added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Apr 18, 2024
@wxiaoguang
Copy link
Contributor

Regression from #30214.

That's why I do not think it should use flex everywhere. It should only be used when we are 100% sure about its children.

@silverwind
Copy link
Member

Flex is fine but I must have overlooked this child 😆

@silverwind silverwind mentioned this issue Apr 18, 2024
Merged
techknowlogick pushed a commit that referenced this issue Apr 21, 2024
@silverwind
Fix flash on dashboard (#30572)
1b1b850 
Fixes #30566, regression from
#30214.
@yp05327
Copy link
Contributor Author

yp05327 commented Apr 23, 2024

image
@silverwind
Is this expected? It looks too long.

@wxiaoguang
Copy link
Contributor

-> Fix flash message for flex-container #30657

DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 30, 2024
@silverwind @earl-warren
Fix flash on dashboard (#30572)
e64e8d2 
Fixes go-gitea/gitea#30566, regression from
go-gitea/gitea#30214.

(cherry picked from commit 1b1b8500aea0a17e999093e65b573ce54ae080ae)

Conflicts:
	web_src/css/base.css
	the conflict is because
	https://codeberg.org/forgejo/forgejo/pulls/3350
	skipped Remove fomantic menu module (gitea#30325)
	and it was not ported.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flash on dashboard silverwind/gitea
3 participants
@silverwind @wxiaoguang @yp05327