Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New pull request imagediff js error #30683

Closed
stuzer05 opened this issue Apr 24, 2024 · 4 comments · Fixed by #30694
Closed

New pull request imagediff js error #30683

stuzer05 opened this issue Apr 24, 2024 · 4 comments · Fixed by #30694
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@stuzer05
Copy link

Description

image

I commited single image and trying to make new pr. See the error

Gitea Version

trunk

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

dokcer

Database

None
@silverwind
Copy link
Member

I can't seem to reproduce. I added a PNG, then updated a PNG, both without that JS error in the diff.

What kind of image is it? PNG? Could you try to reproduce against https://try.gitea.io/?

@silverwind silverwind added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 24, 2024
@wxiaoguang wxiaoguang mentioned this issue Apr 25, 2024
Merged
@wxiaoguang
Copy link
Contributor

-> Refactor imagediff and fix regression bug #30694

@wxiaoguang wxiaoguang added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Apr 25, 2024
@stuzer05
Copy link
Author

I can't seem to reproduce. I added a PNG, then updated a PNG, both without that JS error in the diff.

What kind of image is it? PNG? Could you try to reproduce against https://try.gitea.io/?

Cannot recreate on test instance

@wxiaoguang
Copy link
Contributor

To reproduce: https://try.gitea.io/wxiaoguang/test/commit/d8f8ecd64ac8c9d7c3afcf9b64485e723276fb2e

wxiaoguang added a commit that referenced this issue Apr 25, 2024
@wxiaoguang
Refactor imagediff and fix regression bug (#30694)
fd63b96 
Fix #30683
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor imagediff and fix regression bug wxiaoguang/gitea
3 participants
@silverwind @wxiaoguang @stuzer05