Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep video html5 tags valid in markdown #5448

Closed
laoshaw opened this issue Dec 2, 2018 · 5 comments
Closed

keep video html5 tags valid in markdown #5448

laoshaw opened this issue Dec 2, 2018 · 5 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@laoshaw
Copy link

laoshaw commented Dec 2, 2018

at the moment the video-html5-tag is removed from markdown when it's rendered to html5 page, can we keep it so that we can embed video files directly in markdown and watch it from gitea?

@stale
Copy link

stale bot commented Jan 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 31, 2019
@uberhalit
Copy link

uberhalit commented Feb 2, 2019

It seems like it's not possible to embed a video in markdown. The workaround is pretty bad tbh and does not work as intended with local files: [![video](data/thumbnail.png)](data/video.mp4) won't link to the raw video but instead to the gitea page of the video resource. Workaround to the workaround:
[![video](data/thumbnail.png)](../../../raw/branch/master/data/video.mp4)

@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 7, 2019
@6543
Copy link
Member

6543 commented Sep 6, 2020

@laoshaw can you test if this is still the case?

@laoshaw
Copy link
Author

laoshaw commented Sep 6, 2020

[![video](data/thumbnail.png)](data/video.mp4) will jump to a new gitea page and you can play video.mp4 from there, so not direct embed video in gitea but a workaround.

for [![video](data/thumbnail.png)](../../../raw/branch/master/data/video.mp4) it does not jump to a new page, instead it downloads the file directly.

the best still will be "video" tag support, before then I will use the first option here to get by.

@wxiaoguang
Copy link
Contributor

After #22892 , the tag is kept.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

No branches or pull requests

6 participants