Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make check boxes clickable in issues #7097

Closed
2 of 7 tasks
troygeiger opened this issue Jun 1, 2019 · 12 comments · Fixed by #15791
Closed
2 of 7 tasks

Make check boxes clickable in issues #7097

troygeiger opened this issue Jun 1, 2019 · 12 comments · Fixed by #15791
Labels
issue/bounty This issue has a bounty associated. Whoever opens a PR and gets it merged can claim the bounty. issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@troygeiger
Copy link

  • Gitea version (or commit ref):1.8.2
  • Git version:
  • Operating system:All
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Would it be possible to have the check boxes clickable in issues where the user is assigned or has permission to edit; like the functionality in GitHub?
...

Screenshots

@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 1, 2019
@stale
Copy link

stale bot commented Jul 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 31, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jul 31, 2019
@stale stale bot removed the issue/stale label Jul 31, 2019
@cuzzea
Copy link

cuzzea commented Nov 21, 2019

Any update on this? Would love to see it on.

@lunny
Copy link
Member

lunny commented Nov 21, 2019

Noboy are working on this.

@lordyavin
Copy link

It is a pain the ass to edit a comment to check thing from a todo list. Please schedule this issue for the next milestones.

@zeripath
Copy link
Contributor

This is actually the kind of issue that a small bounty might be able to spur development on.

@davidak
Copy link

davidak commented Jun 7, 2020

It's even worse. You can check boxes after you edited the comment, but it's lost when you reload the page. I would consider that a bug.

https://peertube.social/videos/watch/4be6219e-059d-4650-92cf-f0411f343b47

@zeripath
Copy link
Contributor

zeripath commented Jun 7, 2020

PRs are welcome.

@viceice
Copy link
Contributor

viceice commented Jan 12, 2021

I've written a small greasemonkey / tampermonkey script to make gitea checkboxes clickable, see https://github.com/viceice/UserScripts/blob/master/gitea.cb.helper.js 🙃

@j2L4e
Copy link

j2L4e commented Jan 12, 2021

There's a PR in the making.

A proper implementation needs a prop on the checkbox that states its position in the raw text. This needs to be done on the go side of things. As I haven't written a single line of go in my life and am, frankly, unwilling to dig into it right now, I'd highly appreciate if someone could do it for me so I can take care of the remaining JS stuff.

from #14258 (comment):

Does attaching a data-raw-position-start prop to the rendered checkboxes seem feasible to you? Somewhere around here?
https://github.com/go-gitea/gitea/blob/master/modules/markup/markdown/goldmark.go#L359
I'd expect the AST node to hold information about its origin (i.e. position in raw text)

If all checkboxes have that info attached replacing them becomes trivial and avoids brittle client-side parsing shenanigans.

@viceice
Copy link
Contributor

viceice commented Jan 12, 2021

@j2L4e I saw the pr after i finished my script 😅

@silverwind
Copy link
Member

Github also allows to re-order task list items through a small drag handle on the left. I think this is also something we could implement via the sortablejs dependency that is already present.

@kdumontnu
Copy link
Contributor

Bounty added! Bountysource

If you'd like to promote this, please add

[![Bountysource](https://api.bountysource.com/badge/issue?issue_id=74933799)](https://www.bountysource.com/issues/74933799-make-check-boxes-clickable-in-issues)

To the Issue summary

@kdumontnu kdumontnu added the issue/bounty This issue has a bounty associated. Whoever opens a PR and gets it merged can claim the bounty. label Apr 29, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/bounty This issue has a bounty associated. Whoever opens a PR and gets it merged can claim the bounty. issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants