Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] At Pull Request: download patchfile [Button] #8444

Closed
6543 opened this issue Oct 9, 2019 · 12 comments · Fixed by #8470
Closed

[Feature Request] At Pull Request: download patchfile [Button] #8444

6543 opened this issue Oct 9, 2019 · 12 comments · Fixed by #8470

Comments

@6543
Copy link
Member

6543 commented Oct 9, 2019

add a option to download the patch of the PullRequest

GitLab has a buton and Github does via link

For example:
-> https://patch-diff.githubusercontent.com/raw/alpinelinux/aports/pull/10887.patch
-> https://patch-diff.githubusercontent.com/raw/alpinelinux/aports/pull/10887.diff

@bagasme
Copy link
Contributor

bagasme commented Oct 10, 2019

What about your use case for this feature request?

@zeripath
Copy link
Contributor

It's basically copying GitHub functionality, but allows Gitea to function a bit like a patch server. I could imagine it being necessary to form part of federation or to allow Gitea to integrate with other VCS s.

It's not a high priority issue afaics just a nice to have.

@lunny
Copy link
Member

lunny commented Oct 10, 2019

@6543
Copy link
Member Author

6543 commented Oct 10, 2019

@zeripath you are right :low_prio: ... this is a note for a nice to have fumction
@lunny this are only demo links how it can look like (kan add a gitlab demo too butvdont think it is nessesary)

@zeripath
Copy link
Contributor

I think @lunny means that the code for this is already present:

https://gitea.com/gitea/log/pulls/10.patch

https://gitea.com/gitea/log/pulls/10.diff

(Which are both public PRs so anyone should be able to see.)

I guess the issue is that the links aren't displayed anywhere.

@lunny
Copy link
Member

lunny commented Oct 10, 2019

Yes, so we only need a button or a link on a suitable place.

@6543
Copy link
Member Author

6543 commented Oct 10, 2019

I'm searching in the docu if there is a note ..

@6543
Copy link
Member Author

6543 commented Oct 10, 2019

and I'll search for the button too - perhaps i find a place

@6543 6543 changed the title [Feature Request] At Pull Request: download patchfile [Feature Request] At Pull Request: download patchfile [Button] Oct 10, 2019
@6543
Copy link
Member Author

6543 commented Oct 10, 2019

does gogs have this too?

@6543
Copy link
Member Author

6543 commented Oct 10, 2019

Bildschirmfoto zu 2019-10-10 17-22-19

make "Show Diff Stats" to a dropdown menue "Diff Options" wich contain

  • "Show Stats"
  • "Download Patch"
  • "Download Diff"

?

@guillep2k
Copy link
Member

Sounds reasonable.

@6543
Copy link
Member Author

6543 commented Oct 11, 2019

-> #8470

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants