Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Retry on http requests (dont cancel migration if one error ocure) #8869

Closed
6543 opened this issue Nov 7, 2019 · 2 comments
Closed

Add Retry on http requests (dont cancel migration if one error ocure) #8869

6543 opened this issue Nov 7, 2019 · 2 comments
Labels
type/enhancement An improvement of existing functionality

Comments

@6543
Copy link
Member

6543 commented Nov 7, 2019

gitea Version: 1.11.0+dev-110-gc4bc5abda

Migrating gitea WITHOUT pullrequests and releses works:
https://gitea.com/test-organisation/gitea-mig-test

PullRequest test: https://gitea.com/6543/mig-test2
Releases test: https://gitea.com/6543/rel
@lunny
Copy link
Member

lunny commented Nov 7, 2019

Once there is any network error on the migration, it will rollback. So we have to add some retry for all the http request.

@6543 6543 changed the title migrating gitea failed Add Retry on http requests (dont cancel migration if one error ocure) Nov 10, 2019
@6543
Copy link
Member Author

6543 commented Nov 10, 2019

@lunny title changed ...

@lunny lunny added the type/enhancement An improvement of existing functionality label Nov 10, 2019
@6543 6543 mentioned this issue Nov 15, 2019
Merged
@6543 6543 closed this as completed Nov 30, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lunny @6543