Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastCGI over Unix socket #9295

Closed
clarfonthey opened this issue Dec 8, 2019 · 1 comment · Fixed by #9298
Closed

FastCGI over Unix socket #9295

clarfonthey opened this issue Dec 8, 2019 · 1 comment · Fixed by #9298
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone
1.11.0

Comments

@clarfonthey
Copy link
Contributor

clarfonthey commented Dec 8, 2019 •
edited
Loading

  • Gitea version (or commit ref): Gitea version 1.9.3 built with go1.13.1
  • Git version: git version 2.23.0
  • Operating system: OpenBSD 6.6 GENERIC.MP#0 amd64

Description

Right now, setting PROTOCOL = fcgi allows FCGI over TCP only, which is a bit odd, considering how FastCGI is something that's usually only run locally. If HTTP_ADDR is set to a path for a unix socket, Gitea will error stating that the address is unknown (because it's not actually a hostname).

Because OpenBSD's httpd does not allow full HTTP proxying and only FastCGI, using a unix socket is not possible with this configuration.

This would be a breaking change, but I would personally recommend renaming the unix protocol to unix+http and adding an additional unix+fcgi protocol as well.

Ideally, using the unix protocol without specifying which would emit a warning.
@zeripath
Copy link
Contributor

zeripath commented Dec 8, 2019 •
edited
Loading

I think it would be easiest just to use fcgi+unix - then this doesn't need to be a breaking change.

@zeripath zeripath mentioned this issue Dec 9, 2019
Merged
@lafriks lafriks added this to the 1.11.0 milestone Dec 10, 2019
@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 10, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

FCGI: Allow FCGI over unix sockets zeripath/gitea
3 participants
@lafriks @zeripath @clarfonthey