Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and show force pushes in PR #9549

Closed
jolheiser opened this issue Dec 30, 2019 · 5 comments
Closed

Detect and show force pushes in PR #9549

jolheiser opened this issue Dec 30, 2019 · 5 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/enhancement An improvement of existing functionality

Comments

@jolheiser
Copy link
Member

Similar to GH, a pull request should show when its branch has been force-pushed to.
This is handy/relevant information to know, and might even help determine otherwise confusing behavior.
@bagasme
Copy link
Contributor

bagasme commented Dec 31, 2019

@jolheiser What about the implementation?

@lunny lunny added the type/enhancement An improvement of existing functionality label Dec 31, 2019
@zeripath
Copy link
Contributor

We need another comment type.

The detection code would go in to:

gitea/services/pull/pull.go

Line 217 in 4acca9d

func PushToBaseRepo(pr *models.PullRequest) (err error) {

Or could go in to the pre-receive hook... (Actually instead we should probably prevent direct update of refs/pull paths in pre-receive...)

@stale stale bot added the issue/stale label Feb 29, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 29, 2020
@stale stale bot removed the issue/stale label Feb 29, 2020
@go-gitea go-gitea deleted a comment from stale bot Mar 5, 2020
@tgotwig
Copy link

tgotwig commented May 27, 2020

Would be a really awesome feature! I miss it a lot 😬

@6543
Copy link
Member

6543 commented Jun 2, 2020

did #11167 fix this issue?

@lafriks lafriks added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Oct 26, 2020
@lafriks
Copy link
Member

lafriks commented Oct 26, 2020

Should be fixed by #11167, please reopen if it's not

@lafriks lafriks closed this as completed Oct 26, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@lunny @lafriks @zeripath @6543 @tgotwig @bagasme @jolheiser