-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More expansions in template repositories #10021
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #10021 +/- ##
==========================================
+ Coverage 42.26% 42.26% +<.01%
==========================================
Files 610 611 +1
Lines 80389 80396 +7
==========================================
+ Hits 33974 33977 +3
- Misses 42235 42240 +5
+ Partials 4180 4179 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jan 27, 2020
guillep2k
approved these changes
Jan 27, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 27, 2020
zeripath
added
type/bug
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
labels
Jan 27, 2020
zeripath
approved these changes
Jan 27, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 27, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
… into template_expansion
lunny
reviewed
Jan 28, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
6543
approved these changes
Jan 28, 2020
make lg-tm work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a regression from #9489 where there is a
nil
error.It was not backported (and is correct in
1.11
)This PR adds some extra options for expansions in template repositories.
As well, I decided to move the docs into its own since it's already the entire page.
Adds a new module xstrings (MIT) to avoid maintaining edge-cases for string conversions to various
-case
xstrings is actually the repo that
com
takes itsToSnakeCase
func from anyways.