Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the dataRC reader sooner #16023

Merged
merged 3 commits into from
May 30, 2021
Merged

Close the dataRC reader sooner #16023

merged 3 commits into from
May 30, 2021

Conversation

zeripath
Copy link
Contributor

Fix #15932

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Close the dataRC reader sooner
d0ff409 
Fix go-gitea#15932

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 29, 2021
@zeripath zeripath added this to the 1.15.0 milestone May 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021 •
edited
Loading

Codecov Report

Merging #16023 (282b8a3) into main (effad26) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16023      +/-   ##
==========================================
- Coverage   44.08%   44.08%   -0.01%     
==========================================
  Files         682      682              
  Lines       82373    82375       +2     
==========================================
- Hits        36318    36316       -2     
- Misses      40149    40151       +2     
- Partials     5906     5908       +2
Impacted Files Coverage Δ
routers/repo/editor.go 23.83% <0.00%> (-0.09%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
services/pull/pull.go 43.37% <0.00%> (-0.46%) ⬇️
modules/git/command.go 89.81% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update effad26...282b8a3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2021
lunny
lunny reviewed May 30, 2021
View reviewed changes
routers/repo/editor.go Outdated Show resolved Hide resolved
@zeripath
as per lunny
3759a6b 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 30, 2021
@zeripath zeripath merged commit 36dce0e into go-gitea:main May 30, 2021
@zeripath zeripath deleted the fix-15932-close-earlier branch May 30, 2021 16:38
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@zeripath @AbdulrhmnGhanem
Close the dataRC reader sooner (go-gitea#16023)
d330144 
Fix go-gitea#15932

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Markdown files cannot be edited
5 participants
@zeripath @codecov-commenter @lunny @noerw @GiteaBot