Executable check always returns true for windows #20637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
approved these changes
Aug 2, 2022
GiteaBot
added
the
lgtm/need 1
silverwind
reviewed
Aug 2, 2022
Windows doesn't have the concept of "executable" POSIX bits so for now always return true to minimise doctor and logging noise. Addresses #20636
Co-authored-by: silverwind <me@silverwind.io>
lunny
approved these changes
Aug 4, 2022
GiteaBot
added
lgtm/done
lafriks
approved these changes
Aug 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #20637 +/- ##
=======================================
Coverage ? 46.83%
=======================================
Files ? 979
Lines ? 135950
Branches ? 0
=======================================
Hits ? 63675
Misses ? 64449
Partials ? 7826
Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Please send backport to v1.17 |
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
* Executable check always returns true for windows Windows doesn't have the concept of "executable" POSIX bits so for now always return true to minimise doctor and logging noise. Addresses go-gitea#20636 * gofmt tweak * Update modules/repository/hooks.go Co-authored-by: silverwind <me@silverwind.io> * gofmt comment line Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lauris BH <lauris@nix.lv>
zeripath
pushed a commit
to zeripath/gitea
that referenced
this pull request
Aug 17, 2022
Backport go-gitea#20637 Windows doesn't have the concept of "executable" POSIX bits so for now always return true to minimise doctor and logging noise. Addresses go-gitea#20636 Co-authored-by: silverwind <me@silverwind.io>
zeripath
added a commit
that referenced
this pull request
Aug 17, 2022
Backport #20637 Windows doesn't have the concept of "executable" POSIX bits so for now always return true to minimise doctor and logging noise. Addresses #20636 Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: JonRB <4564448+eeyrjmr@users.noreply.github.com> Co-authored-by: silverwind <me@silverwind.io>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows doesn't have the concept of "executable" POSIX bits so for now always return true to minimise doctor and logging noise. Fixes: #20636