Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove semver compatible flag and change pypi to an array of test cases (#21708) #21730

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Nov 9, 2022

Backport (#21708)

This addresses #21707 and adds a second package test case for a non-semver compatible version (this might be overkill though since you could also edit the old package version to have an epoch in front and see the error, this just seemed more flexible for the future).

Co-authored-by: KN4CK3R admin@oldschoolhack.me

…es (go-gitea#21708)

Backport (go-gitea#21708)

This addresses go-gitea#21707 and adds a second package test case for a
non-semver compatible version (this might be overkill though since you
could also edit the old package version to have an epoch in front and
see the error, this just seemed more flexible for the future).

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 9, 2022
@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/packages labels Nov 9, 2022
@lunny lunny added this to the 1.18.0 milestone Nov 9, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 9, 2022
@lunny lunny merged commit 805a14c into go-gitea:release/v1.18 Nov 9, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/packages type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants