Improve documentation for PAM and static deployment #21866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes proposed in [referenced issue 21845](go-gitea#21845)
wxiaoguang
reviewed
Nov 19, 2022
GiteaBot
added
the
lgtm/need 2
Rebase to upstream latest.
- `lbmethod_byrequests` is actually not required for HTTPS. - `STATIC_URL_PREFIX` _should_ work on an uninitialized system (it doesn't on mine though. - Added several documentation improvements recommended by the project owners.
wxiaoguang
approved these changes
Nov 19, 2022
GiteaBot
added
lgtm/need 1
zeripath
changed the title
zeripath
reviewed
Nov 20, 2022
Comment on lines
176
to
179
| **Note**: Once a user has been authenticated use of items such as SSH public | ||
| keys _may_ bypass the login check system. Therefore, if disabling a user, it | ||
| is recommended to manually disable the account in Gitea using the built-in user | ||
| manager as well. |
There was a problem hiding this comment.
Suggested change
| **Note**: Once a user has been authenticated use of items such as SSH public | |
| keys _may_ bypass the login check system. Therefore, if disabling a user, it | |
| is recommended to manually disable the account in Gitea using the built-in user | |
| manager as well. | |
| **Note**: If a user has added SSH public keys into Gitea, the use of these | |
| keys _may_ bypass the login check system. Therefore, if you wish to disable a user who | |
| authenticates with PAM, you _should_ also manually disable the account in Gitea using the | |
| built-in user manager. |
There was a problem hiding this comment.
I didn't want to state this because I really don't know and would just be assuming (and you know where that gets people), but I'm guessing that this is also the reason that the application needs read access to the user file /etc/shadow.
There was a problem hiding this comment.
There is no check performed against PAM when a user logs in with ssh - so if it is intended for them to be disabled admins will need to do this disabling manually.
- Changed verbiage around use of SSH public keys.
zeripath
approved these changes
Nov 20, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 21, 2022
* giteaofficial/main: Improve documentation for PAM and static deployment (go-gitea#21866) Add package registry cleanup rules (go-gitea#21658) Support comma-delimited string as labels in issue template (go-gitea#21831) Fix wechatwork webhook sends empty content in PR review (go-gitea#21762) Show syntax lexer name in file view/blame (go-gitea#21814) Add `context.Context` to more methods (go-gitea#21546) Timeline and color tweaks (go-gitea#21799) Fix webpack license warning (go-gitea#21815) chore: add webpack export type check (go-gitea#21857) Prevent dangling user redirects (go-gitea#21856) Fix "build from source" document to clarify the `bindata` tag is required. (go-gitea#21853) Bump loader-utils from 2.0.3 to 2.0.4 (go-gitea#21852) Do not allow Ghost access to limited visible user/org (go-gitea#21849) Fix setting HTTP headers after write (go-gitea#21833)
fsologureng
pushed a commit
to fsologureng/gitea
that referenced
this pull request
Nov 22, 2022
## Changes proposed in [referenced issue 21845][1] - Expand PAM configuration description with working examples. - Clarify `STATIC_URL_PREFIX` use (include "assets" and only works after database has been initialized) - Add note for HTTPS proxy support VIA Apache. [1]: go-gitea#21845
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in referenced issue 21845
STATIC_URL_PREFIXuse (include "assets" and only works after database has been initialized)