From e3434b7bede47b633d3b224b26c35353a07c59d5 Mon Sep 17 00:00:00 2001 From: fsologureng Date: Wed, 22 Mar 2023 17:09:22 -0300 Subject: [PATCH] Changed foomantic dropdowns to the combobox+listbox ARIA design pattern - Changed scope application of aria.js functions to apply it after all widgets are initialized. - Improve a11y structure of: - Reactions in issue/pr comments view. - Comment options in issue/pr comments view. - Milestone dropdown in repo issue/pr view. - Projects dropdown in repo issue/pr view. - Assignees dropdown in repo issue/pr view. - Reviewers dropdown in repo pr view. - Due date dropdown in repo issue/pr view. - Dependency dropdown in repo issue/pr view. - Reference copy button in repo issue/pr view. - Language selector. - Create... button. - Profile and settings... button. - Add label for some buttons. - Remove `dropdown` class to an svg which generates false positives --- options/locale/locale_en-US.ini | 6 + templates/base/footer_content.tmpl | 4 +- templates/base/head_navbar.tmpl | 9 +- .../issue/labels/labels_selector_field.tmpl | 4 +- templates/repo/issue/new_form.tmpl | 20 +- .../repo/issue/view_content/add_reaction.tmpl | 6 +- .../repo/issue/view_content/context_menu.tmpl | 2 +- .../repo/issue/view_content/sidebar.tmpl | 30 +-- web_src/js/features/aria.js | 186 ++++++++++++------ web_src/js/features/common-global.js | 5 - web_src/js/features/repo-issue-content.js | 4 +- web_src/js/index.js | 2 + 12 files changed, 177 insertions(+), 101 deletions(-) diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini index da925a27f5d3d..667ca4e1f6dde 100644 --- a/options/locale/locale_en-US.ini +++ b/options/locale/locale_en-US.ini @@ -14,10 +14,13 @@ powered_by = Powered by %s page = Page template = Template language = Language +language_select = Select a language notifications = Notifications active_stopwatch = Active Time Tracker create_new = Create… +create_new_select = Select an item to create… user_profile_and_more = Profile and Settings… +user_action_select = Select a user action to do… signed_in_as = Signed in as enable_javascript = This website works better with JavaScript. toc = Table of Contents @@ -918,6 +921,7 @@ mirror_password_help = Change the username to erase a stored password. watchers = Watchers stargazers = Stargazers forks = Forks +reactions = Reactions pick_reaction = Pick your reaction reactions_more = and %d more unit_disabled = The site administrator has disabled this repository section. @@ -1363,6 +1367,7 @@ issues.draft_title = Draft issues.num_comments = %d comments issues.commented_at = `commented %s` issues.delete_comment_confirm = Are you sure you want to delete this comment? +issues.context.options_button = Comment Options issues.context.copy_link = Copy Link issues.context.quote_reply = Quote Reply issues.context.reference_issue = Reference in New Issue @@ -1545,6 +1550,7 @@ issues.content_history.delete_from_history = Delete from history issues.content_history.delete_from_history_confirm = Delete from history? issues.content_history.options = Options issues.reference_link = Reference: %s +issues.reference_button = Copy reference to clipboard compare.compare_base = base compare.compare_head = compare diff --git a/templates/base/footer_content.tmpl b/templates/base/footer_content.tmpl index 53d0a2c77cf18..05f3973fbcacb 100644 --- a/templates/base/footer_content.tmpl +++ b/templates/base/footer_content.tmpl @@ -19,9 +19,9 @@ {{if .ShowFooterBranding}} {{svg "octicon-mark-github"}}GitHub {{end}} -