From cbf36b148564408597dfa280c7f6275a782e6360 Mon Sep 17 00:00:00 2001 From: tiny6996 Date: Sun, 22 Jan 2023 15:25:36 -0600 Subject: [PATCH 1/4] fixes #22571 by change conn string --- custom/conf/app.example.ini | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini index eca1184ff98f4..6afa4c85b747d 100644 --- a/custom/conf/app.example.ini +++ b/custom/conf/app.example.ini @@ -1721,7 +1721,7 @@ ROUTER = console ;INTERVAL = 60 ;; ;; For "redis" and "memcache", connection host address -;; redis: network=tcp,addr=:6379,password=macaron,db=0,pool_size=100,idle_timeout=180 +;; redis: reddis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s ;; memcache: `127.0.0.1:11211` ;; twoqueue: `{"size":50000,"recent_ratio":0.25,"ghost_ratio":0.5}` or `50000` ;HOST = @@ -1760,7 +1760,7 @@ ROUTER = console ;; Provider config options ;; memory: doesn't have any config yet ;; file: session file path, e.g. `data/sessions` -;; redis: network=tcp,addr=:6379,password=macaron,db=0,pool_size=100,idle_timeout=180 +;; redis: reddis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s ;; mysql: go-sql-driver/mysql dsn config string, e.g. `root:password@/session_table` ;PROVIDER_CONFIG = data/sessions ; Relative paths will be made absolute against _`AppWorkPath`_. ;; @@ -2380,8 +2380,8 @@ ROUTER = console ;QUEUE_LENGTH = 1000 ;; ;; Task queue connection string, available only when `QUEUE_TYPE` is `redis`. -;; If there is a password of redis, use `addrs=127.0.0.1:6379 password=123 db=0`. -;QUEUE_CONN_STR = "addrs=127.0.0.1:6379 db=0" +;; If there is a password of redis, use `reddis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s`. +;QUEUE_CONN_STR = "reddis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s" ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; From 1f285b58657965ad845357e70a2c88101753021a Mon Sep 17 00:00:00 2001 From: tiny6996 Date: Sun, 22 Jan 2023 15:38:57 -0600 Subject: [PATCH 2/4] Fix spelling error Co-authored-by: Yarden Shoham --- custom/conf/app.example.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini index 6afa4c85b747d..eefda55eedebc 100644 --- a/custom/conf/app.example.ini +++ b/custom/conf/app.example.ini @@ -1760,7 +1760,7 @@ ROUTER = console ;; Provider config options ;; memory: doesn't have any config yet ;; file: session file path, e.g. `data/sessions` -;; redis: reddis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s +;; redis: `redis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s` ;; mysql: go-sql-driver/mysql dsn config string, e.g. `root:password@/session_table` ;PROVIDER_CONFIG = data/sessions ; Relative paths will be made absolute against _`AppWorkPath`_. ;; From c8eaa8f8b62cac4b1a976a3b973a6fc861aaf998 Mon Sep 17 00:00:00 2001 From: tiny6996 Date: Sun, 22 Jan 2023 15:39:13 -0600 Subject: [PATCH 3/4] Fix Spelling Error Co-authored-by: Yarden Shoham --- custom/conf/app.example.ini | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini index eefda55eedebc..6e7944530713b 100644 --- a/custom/conf/app.example.ini +++ b/custom/conf/app.example.ini @@ -2380,8 +2380,8 @@ ROUTER = console ;QUEUE_LENGTH = 1000 ;; ;; Task queue connection string, available only when `QUEUE_TYPE` is `redis`. -;; If there is a password of redis, use `reddis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s`. -;QUEUE_CONN_STR = "reddis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s" +;; If there is a password of redis, use `redis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s`. +;QUEUE_CONN_STR = "redis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s" ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; From 1ae32580835bbefcb89d68d71acc3865a92a2a97 Mon Sep 17 00:00:00 2001 From: zeripath Date: Sun, 22 Jan 2023 22:29:43 +0000 Subject: [PATCH 4/4] Apply suggestions from code review Co-authored-by: Yarden Shoham --- custom/conf/app.example.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/custom/conf/app.example.ini b/custom/conf/app.example.ini index 6e7944530713b..b5559b1a954e1 100644 --- a/custom/conf/app.example.ini +++ b/custom/conf/app.example.ini @@ -1721,7 +1721,7 @@ ROUTER = console ;INTERVAL = 60 ;; ;; For "redis" and "memcache", connection host address -;; redis: reddis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s +;; redis: `redis://127.0.0.1:6379/0?pool_size=100&idle_timeout=180s` ;; memcache: `127.0.0.1:11211` ;; twoqueue: `{"size":50000,"recent_ratio":0.25,"ghost_ratio":0.5}` or `50000` ;HOST =