Set opaque background on markup and images #23578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yardenshoham
approved these changes
Mar 19, 2023
GiteaBot
added
the
lgtm/need 1
|
There is a small regression in dropzone attachment rendering because of the padding change, checking... |
|
Regression fixed. Dropzone
|
zeripath
approved these changes
Mar 20, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
🎺 🤖 |
jolheiser
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 22, 2023
* upstream/main: Use a general approch to improve a11y for all checkboxes and dropdowns. (go-gitea#23542) [skip ci] Updated translations via Crowdin Update PR documentation (go-gitea#23620) Set opaque background on markup and images (go-gitea#23578) Decouple the issue-template code from comment_tab.tmpl (go-gitea#23556) Remove `id="comment-form"` dead code, fix tag (go-gitea#23555) Introduce path Clean/Join helper functions (go-gitea#23495) Remove conflicting CSS rules on notifications, improve notifications table (go-gitea#23565) Remove @metalmatze as maintainer (go-gitea#23612) Keep (add if not existing) xmlns attribute for generated SVG images (go-gitea#23410)
wxiaoguang
reviewed
Mar 27, 2023
| @@ -3,6 +3,7 @@ | |||
| font-size: 16px; | |||
| line-height: 1.5 !important; | |||
| word-wrap: break-word; | |||
| background: var(--color-box-body); | |||
There was a problem hiding this comment.
I guess it should be inherit, then we do not need to fix various colors again and again.
Or just remove it? I can't see difference without this style.
There was a problem hiding this comment.
background does not inherit or cascade by default, so inherit would only inherit from the direct element parent, but in the release list we actually would want to inherit from body.
wxiaoguang
reviewed
Mar 28, 2023
| @@ -2740,6 +2740,12 @@ | |||
| width: 100% !important; | |||
| max-width: 100% !important; | |||
| margin: 0 !important; | |||
| padding: 0 !important; | |||
There was a problem hiding this comment.
I would also suggest to revert this change.
It causes unnecessary overwriting problems.
silverwind
added a commit
that referenced
this pull request
Apr 7, 2023
Fix regression from #23578. Only visible on arc-green. Before: <img width="997" alt="Screenshot 2023-03-27 at 19 14 21" src="https://user-images.githubusercontent.com/115237/228016589-e7cabfb9-bfd0-45fd-9407-6b76c665ed1a.png"> After: <img width="1000" alt="Screenshot 2023-03-27 at 19 14 05" src="https://user-images.githubusercontent.com/115237/228016600-db2e6002-4e2c-4d18-8393-9d7e1f525acb.png"> Fixes: #20625 Fixes: #23718
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<hr>paddingis provided by the.markupelement instead of its parent, matching the file rendering view which does the same.Before:
After:
Example documents:
https://try.gitea.io/silverwind/symlink-test/src/branch/master/test-page.md
https://github.com/silverwind/symlink-test/blob/master/test-page.md