Use shared/issueicon template in projects
#24922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
silverwind
added
type/refactoring
lunny
reviewed
May 25, 2023
delvh
approved these changes
May 25, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 25, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wxiaoguang
reviewed
May 25, 2023
GiteaBot
removed
the
reviewed/wait-merge
|
But the |
Adding those classes to the parent node in the issue list slighly misaligns the icon (the icon there is not vertically centered in its container there). I'm all for sharing more HTML, but in this case I just don't see it feasible and the template should only return the BTW, If ever necessary, we can add dict arguments to the template to alter behaviour like size for example. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 26, 2023
* upstream/main: Use the type RefName for all the needed places and fix pull mirror sync bugs (go-gitea#24634) [skip ci] Updated translations via Crowdin Add Link to Stars and Forks Page to Repo List (go-gitea#24931) Fix documentation ref (go-gitea#24934) Add Chinese docs for help, contribution and development (go-gitea#24925) Merge two translation contributing documents (go-gitea#23939) Add the ability to pin Issues (go-gitea#24406) Use `shared/issueicon` template in projects (go-gitea#24922) Allow skipping forks and mirrors from being indexed (go-gitea#23187) Add Chinese documentations for Actions (go-gitea#24902) # Conflicts: # templates/repo/issue/view_content/sidebar.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can reuse the recently created subtemplate here. I also checked the whole templates for similar constructs, these appear to be the only one.