Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commits dropdown in PR files view and allow commit by commit review #25528

Merged
merged 88 commits into from
Jul 28, 2023
Merged

Add commits dropdown in PR files view and allow commit by commit review #25528

merged 88 commits into from
Jul 28, 2023

Commits on Jun 26, 2023

  1. Add commits dropdown in PR files view 

    when selecting a commit only the changes of this commit will
be shown.
    @sebastian-sauer
    sebastian-sauer committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    acbd8dd View commit details
    Browse the repository at this point in the history

  2. Disable File-Viewed when reviewing a single commit

    @sebastian-sauer
    sebastian-sauer committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    bd1551c View commit details
    Browse the repository at this point in the history

  3. Add ellipsis and divider

    @sebastian-sauer
    sebastian-sauer committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    862ffc8 View commit details
    Browse the repository at this point in the history

  4. Add styles and ellipsis

    @sebastian-sauer
    sebastian-sauer committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    836ee9b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Add max-height and scroll for list of commits

    @sebastian-sauer
    sebastian-sauer committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    77a81bb View commit details
    Browse the repository at this point in the history

  2. Update web_src/css/repo.css

    @silverwind
    silverwind authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    45b7567 View commit details
    Browse the repository at this point in the history

  3. Reduce padding of commit-menu 

    and margin of divider
    @sebastian-sauer
    sebastian-sauer committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a763afe View commit details
    Browse the repository at this point in the history

  4. ui enhancements

    @silverwind
    silverwind committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a63c7b9 View commit details
    Browse the repository at this point in the history

  5. add jump class to correctly hide tippy

    @silverwind
    silverwind committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    eaa02c7 View commit details
    Browse the repository at this point in the history

  6. tweak locale

    @silverwind
    silverwind committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    bfab42b View commit details
    Browse the repository at this point in the history

  7. remove unnecessary display

    @silverwind
    silverwind committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b390786 View commit details
    Browse the repository at this point in the history

  8. reduce height some more for small screens

    @silverwind
    silverwind committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d439c1f View commit details
    Browse the repository at this point in the history

  9. calculate len only once

    @silverwind
    silverwind committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    2f275a6 View commit details
    Browse the repository at this point in the history

  10. Check if given commit sha exists on this PR

    @sebastian-sauer
    sebastian-sauer committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    9653f1a View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Improve code

    @sebastian-sauer
    sebastian-sauer committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    7049c71 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    f45980b View commit details
    Browse the repository at this point in the history

  3. Support three github urls 

    * show single commits diff in PR context: /pull/{pull-id}/commits/{sha1}
* show diff of all commits since (of PR) : /pull/{pull-id}/files/{sha1}
* show diff of a commit range (of PR): /pull/{pull-id}/files/{sha1}..{sha1}
    @sebastian-sauer
    sebastian-sauer committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    5b8b4cb View commit details
    Browse the repository at this point in the history

  4. Make uris behave like github

    @sebastian-sauer
    sebastian-sauer committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    971d0a0 View commit details
    Browse the repository at this point in the history

  5. Make commit selector a vue component

    @sebastian-sauer
    sebastian-sauer committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    059c55b View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    1991bf8 View commit details
    Browse the repository at this point in the history

  2. Improve var naming and add comments

    @sebastian-sauer
    sebastian-sauer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    4d1a4bf View commit details
    Browse the repository at this point in the history

  3. Fix displayed commit for single commits

    @sebastian-sauer
    sebastian-sauer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    451f644 View commit details
    Browse the repository at this point in the history

  4. Disable submitting review when not viewing the full diff

    @sebastian-sauer
    sebastian-sauer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2d4accf View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    c60b78f View commit details
    Browse the repository at this point in the history

  6. Add integration tests for different PR diff endpoints

    @sebastian-sauer
    sebastian-sauer committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    0e105bb View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. fix fmt

    @sebastian-sauer
    sebastian-sauer committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    563d371 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/allow_review_commit_by_commit

    @sebastian-sauer
    sebastian-sauer authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0328434 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6d6d846 View commit details
    Browse the repository at this point in the history

  2. Add integration test with more commits 

    to ensure commits are checked correctly
    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8588935 View commit details
    Browse the repository at this point in the history

  3. Remove button loading artifacts until vue component is loaded 

    we just display the svg already, so there is no flickering / relayout
when the vue component is initialized
    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    36f3af2 View commit details
    Browse the repository at this point in the history

  4. Add comment explaining why the svg is available

    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    91217eb View commit details
    Browse the repository at this point in the history

  5. Fix integration tests 

    after adding a new repo multiple numbers had to be corrected
    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    43a8a15 View commit details
    Browse the repository at this point in the history

  6. Add "Show changes since your last review" functionality

    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6828bfd View commit details
    Browse the repository at this point in the history

  7. Add missing divider

    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    863edf6 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    076c5ee View commit details
    Browse the repository at this point in the history

  9. Fix lint

    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ea83620 View commit details
    Browse the repository at this point in the history

  10. Fix more tests

    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    2b37ae4 View commit details
    Browse the repository at this point in the history

  11. Fix fixture

    @sebastian-sauer
    sebastian-sauer committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1824329 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Merge branch 'main' into feature/allow_review_commit_by_commit

    @sebastian-sauer
    sebastian-sauer authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    9dde031 View commit details
    Browse the repository at this point in the history

  2. Update web_src/js/components/DiffCommitSelector.vue

    @silverwind
    silverwind authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ad226d7 View commit details
    Browse the repository at this point in the history

  3. Fix ci error

    @sebastian-sauer
    sebastian-sauer committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    60e1e53 View commit details
    Browse the repository at this point in the history

  4. lowercase json keys

    @sebastian-sauer
    sebastian-sauer committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    9a3fe9c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/allow_review_commit_by_commit' of https://githu… 

    …b.com/sebastian-sauer/gitea into feature/allow_review_commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    5cf8473 View commit details
    Browse the repository at this point in the history

  6. Use frontend fetch to get the data

    @sebastian-sauer
    sebastian-sauer committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1590ad5 View commit details
    Browse the repository at this point in the history

  7. Fix changes since last review url

    @sebastian-sauer
    sebastian-sauer committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d2b065a View commit details
    Browse the repository at this point in the history

  8. Fix order of commits

    @sebastian-sauer
    sebastian-sauer committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    109394c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Refactors and add hint for commit range

    @sebastian-sauer
    sebastian-sauer committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    bcb7c09 View commit details
    Browse the repository at this point in the history

  2. Add missing translation

    @sebastian-sauer
    sebastian-sauer committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    429e41f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    0aef59c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge branch 'main' into feature/allow_review_commit_by_commit

    @sebastian-sauer
    sebastian-sauer authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    5fc1492 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
    @sebastian-sauer @KN4CK3R
    sebastian-sauer and KN4CK3R authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    08094a0 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    333ae56 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Add loading animation 

    and remove global css and move it to vue component
    @sebastian-sauer
    sebastian-sauer committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ec0f21c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/allow_review_commit_by_commit

    @silverwind
    silverwind authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ba32e3d View commit details
    Browse the repository at this point in the history

  3. Use ShortSha for UI 

    and fix json property names
    @sebastian-sauer
    sebastian-sauer committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    fea2a66 View commit details
    Browse the repository at this point in the history

  4. Add max-width and fix double border-top

    @sebastian-sauer
    sebastian-sauer committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    7518ec1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/allow_review_commit_by_commit' of https://githu… 

    …b.com/sebastian-sauer/gitea into feature/allow_review_commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    91a6d0d View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Merge branch 'main' into feature/allow_review_commit_by_commit

    @silverwind
    silverwind authored Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f3895a1 View commit details
    Browse the repository at this point in the history

  2. css tweaks

    @silverwind
    silverwind committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    bbf9676 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Fix committer display in vue component

    @sebastian-sauer
    sebastian-sauer committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    dcbdb2e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Merge branch 'main' into feature/allow_review_commit_by_commit

    @sebastian-sauer
    sebastian-sauer authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    34c9154 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8307701 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/allow_review_commit_by_commit' of https://githu… 

    …b.com/sebastian-sauer/gitea into feature/allow_review_commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8a7c4a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    fe0e4c9 View commit details
    Browse the repository at this point in the history

  2. Fix case of PR

    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e005ee3 View commit details
    Browse the repository at this point in the history

  3. Remove div selector

    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    243ade4 View commit details
    Browse the repository at this point in the history

  4. Improve check for empty last review commit ha

    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1018cfd View commit details
    Browse the repository at this point in the history

  5. Improve check for empty commit sha

    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    78b1006 View commit details
    Browse the repository at this point in the history

  6. Improve routes 

    add sha spec and add second route for specified range
    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    21f9407 View commit details
    Browse the repository at this point in the history

  7. Show all changes in PR if all commits are selected

    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    92e9a47 View commit details
    Browse the repository at this point in the history

  8. Fix opening the popup when pressing enter

    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    feba85a View commit details
    Browse the repository at this point in the history

  9. Extract logic to services

    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    754d242 View commit details
    Browse the repository at this point in the history

  10. Fix lint

    @sebastian-sauer
    sebastian-sauer committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    bf424e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Fix relative-time in Firefox 

    it needs a well formatted time string
chrome allows some more variations
    @sebastian-sauer
    sebastian-sauer committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c57289e View commit details
    Browse the repository at this point in the history

  2. Use light color for show all commits message

    @sebastian-sauer
    sebastian-sauer committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9d025f4 View commit details
    Browse the repository at this point in the history

  3. Disable Changes since last review if no new commits are available 

    and reset lastreviewcommitsha if the commit is not in our commits list
    @sebastian-sauer
    sebastian-sauer committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2d6c974 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge remote-tracking branch 'origin/main' into feature/allow_review_… 

    …commit_by_commit
    @sebastian-sauer
    sebastian-sauer committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    359a3df View commit details
    Browse the repository at this point in the history

  2. Make dropdown usable with keyboard

    @sebastian-sauer
    sebastian-sauer committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    985d9de View commit details
    Browse the repository at this point in the history

  3. Add "Show All commits" link

    @sebastian-sauer
    sebastian-sauer committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    1724181 View commit details
    Browse the repository at this point in the history

  4. Add improved range selection

    @sebastian-sauer
    sebastian-sauer committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    f7acf4a View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. fix XORM bug

    @wxiaoguang
    wxiaoguang committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3f9749f View commit details
    Browse the repository at this point in the history

  2. fine tune

    @wxiaoguang
    wxiaoguang committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    5e3df0e View commit details
    Browse the repository at this point in the history

  3. fine tune

    @wxiaoguang
    wxiaoguang committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    e352233 View commit details
    Browse the repository at this point in the history

  4. refactor dom event listener

    @wxiaoguang
    wxiaoguang committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    57f4864 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/allow_review_commit_by_commit

    @GiteaBot
    GiteaBot authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    39b4d0c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into feature/allow_review_commit_by_commit

    @GiteaBot
    GiteaBot authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    59588a5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into feature/allow_review_commit_by_commit

    @delvh
    delvh authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    275750e View commit details
    Browse the repository at this point in the history

  8. Fix indentation

    @sebastian-sauer
    sebastian-sauer committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    f4438d1 View commit details
    Browse the repository at this point in the history