Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update enable_prune even if mirror_interval is not provided #28905

Merged
merged 4 commits into from
Jan 25, 2024

Commits on Jan 23, 2024

  1. fix: update enable_prune even if mirror_interval is not provided

    Currently, the `updateMirror` function which update the mirror interval and enable prune properties is only executed by the `Edit` function. But it is only triggered if `opts.MirrorInterval` is not null, even if `opts.EnablePrune` is not null.
    
    With this patch, it is now possible to update the enable_prune property with a patch request without modifying the mirror_interval.
    
    ## Example request with httpie
    
    ### Currently:
    **Does nothing**
    ```bash
    http PATCH https://gitea.your-server/api/v1/repos/myOrg/myRepo "enable_prune:=false" -A bearer -a $gitea_token
    ```
    
    **Updates both properties**
    ```bash
    http PATCH https://gitea.your-server/api/v1/repos/myOrg/myRepo "enable_prune:=false" "mirror_interval=10m" -A bearer -a $gitea_token
    ```
    
    ### With the patch
    **Updates enable_prune only**
    ```bash
    http PATCH https://gitea.your-server/api/v1/repos/myOrg/myRepo "enable_prune:=false" -A bearer -a $gitea_token
    ```
    Anthony-Jhoiro committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    eed8a7c View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    e37654b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e7e5670 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9a7cb35 View commit details
    Browse the repository at this point in the history