From db6a0170084c109ac51f429d815fe58ffe5ccfa6 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 16 Feb 2024 00:06:31 +0100 Subject: [PATCH 1/5] Disable parallel Make execution Ref: https://www.gnu.org/software/make/manual/html_node/Parallel-Disable.html --- Makefile | 3 +++ README.md | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index da4806d9c4105..97187dde76164 100644 --- a/Makefile +++ b/Makefile @@ -988,3 +988,6 @@ docker: # This endif closes the if at the top of the file endif + +# Disable parallel execution because it would break many targets +.NOTPARALLEL: diff --git a/README.md b/README.md index 174e37769c1bb..adba74d8bb896 100644 --- a/README.md +++ b/README.md @@ -89,8 +89,6 @@ The `build` target is split into two sub-targets: Internet connectivity is required to download the go and npm modules. When building from the official source tarballs which include pre-built frontend files, the `frontend` target will not be triggered, making it possible to build without Node.js. -Parallelism (`make -j `) is not supported. - More info: https://docs.gitea.com/installation/install-from-source ## Using From bf0deeb8f8ece48cb56cfb94b5ed538ffcc6713e Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 16 Feb 2024 00:09:34 +0100 Subject: [PATCH 2/5] improve --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 97187dde76164..80a2011c0805e 100644 --- a/Makefile +++ b/Makefile @@ -989,5 +989,5 @@ docker: # This endif closes the if at the top of the file endif -# Disable parallel execution because it would break many targets +# Disable parallel execution because it would break some targets that don't specify exact dependencies .NOTPARALLEL: From 3c44806ab7ded9a07b032bdb01ca7a4fb36cb653 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 16 Feb 2024 00:27:06 +0100 Subject: [PATCH 3/5] expand comment --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 80a2011c0805e..a7dc796d1c6ca 100644 --- a/Makefile +++ b/Makefile @@ -989,5 +989,7 @@ docker: # This endif closes the if at the top of the file endif -# Disable parallel execution because it would break some targets that don't specify exact dependencies +# Disable parallel execution because it would break some targets don't specify +# exact dependencies like 'backend' which does currently not depend on +# 'frontend' which enables Node.js-less builds from source tarballs. .NOTPARALLEL: From c2695e7577fece4f10ad4c048fbafeb86be6a456 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 16 Feb 2024 00:28:56 +0100 Subject: [PATCH 4/5] wording --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index a7dc796d1c6ca..15736ce17574b 100644 --- a/Makefile +++ b/Makefile @@ -989,7 +989,7 @@ docker: # This endif closes the if at the top of the file endif -# Disable parallel execution because it would break some targets don't specify -# exact dependencies like 'backend' which does currently not depend on -# 'frontend' which enables Node.js-less builds from source tarballs. +# Disable parallel execution because it would break some targets that don't +# specify exact dependencies like 'backend' which does currently not depend +# on 'frontend' which enables Node.js-less builds from source tarballs. .NOTPARALLEL: From 0eac813634a3c9507cae74c5bce787e55a2c5110 Mon Sep 17 00:00:00 2001 From: silverwind Date: Fri, 16 Feb 2024 00:31:36 +0100 Subject: [PATCH 5/5] wording --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 15736ce17574b..3065d9e683bf2 100644 --- a/Makefile +++ b/Makefile @@ -991,5 +991,5 @@ endif # Disable parallel execution because it would break some targets that don't # specify exact dependencies like 'backend' which does currently not depend -# on 'frontend' which enables Node.js-less builds from source tarballs. +# on 'frontend' to enable Node.js-less builds from source tarballs. .NOTPARALLEL: