Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Citation modal responsiveness and clipboard copy #29799

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

silverwind
Copy link
Member

The modal was broken in two ways:

  • On small screens, the input box was partially hanging outside the modal. Fixed with flexbox and increased modal width.
  • The clipboard copy was not working because the modal had both data-clipboard-text and data-clipboard-target, while we only support one of those. Made a small tweak in clipboard as well so that it will still fall back to target if text is empty.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2024
@silverwind silverwind added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2024
@github-actions github-actions bot added modifies/frontend modifies/templates This PR modifies the template files modifies/js labels Mar 14, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2024
@wxiaoguang wxiaoguang removed the backport/v1.21 This PR should be backported to Gitea 1.21 label Mar 15, 2024
@wxiaoguang
Copy link
Contributor

I do not think this could be backported, some code is 1.22-only.

@silverwind
Copy link
Member Author

It should theoretically apply to 1.21, not many changes around these parts. But yeah I'm not thrilled about another manual backport. Let's still see whether GiteaBot can do it.

@silverwind silverwind added backport/v1.21 This PR should be backported to Gitea 1.21 reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 15, 2024
@silverwind silverwind enabled auto-merge (squash) March 15, 2024 02:01
@wxiaoguang
Copy link
Contributor

It can't, because I am sure the "copy" code was changed by #29379 , it is only in 1.22

@silverwind silverwind removed the backport/v1.21 This PR should be backported to Gitea 1.21 label Mar 15, 2024
@silverwind
Copy link
Member Author

silverwind commented Mar 15, 2024

Ah I see, #29379 had broken this copy button. The style fix is barely worth backporting imho.

@silverwind silverwind merged commit 94512ee into go-gitea:main Mar 15, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 15, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 15, 2024
@6543 6543 modified the milestones: 1.23.0, 1.22.0 Mar 16, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants