-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Citation modal responsiveness and clipboard copy #29799
Conversation
I do not think this could be backported, some code is 1.22-only. |
It should theoretically apply to 1.21, not many changes around these parts. But yeah I'm not thrilled about another manual backport. Let's still see whether GiteaBot can do it. |
It can't, because I am sure the "copy" code was changed by #29379 , it is only in 1.22 |
Ah I see, #29379 had broken this copy button. The style fix is barely worth backporting imho. |
The modal was broken in two ways:
data-clipboard-text
anddata-clipboard-target
, while we only support one of those. Made a small tweak in clipboard as well so that it will still fall back to target if text is empty.