Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup app.example.ini for task section, which is now queue.task #30555

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Fixup app.example.ini for task section, which is now queue.task #30555

merged 5 commits into from
Apr 18, 2024

Conversation

xor-gate
Copy link
Contributor

I am running gitea v1.21.11 and was using the app.example.ini from git on the previous tag. It seems [task] has been deprecated in favor of [queue.task]. See #30554

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 18, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2024
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Apr 18, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2024
@lunny lunny added backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 labels Apr 18, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 18, 2024 •
edited
Loading

I think this section should be removed (update: this means the [task] section), because all other types of queues also shared the same section above:

image

@wxiaoguang
Copy link
Contributor

The task section in config cheatsheet should also be removed:

image

@xor-gate
custom/conf/app.example.ini: Remove queue section
78be128 
docs/content/administration/config-cheat-sheet.en-us.md: Remove task section
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2024
@xor-gate
Copy link
Contributor Author

@wxiaoguang fixed in 78be128. I'm unable to read chinese so the cheatsheet must be modified by someone who can read and write it.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2024
@wxiaoguang
Copy link
Contributor

Made some changes, I think we should keep [queue], remove [task]

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2024
@xor-gate
Copy link
Contributor Author

Made some changes, I think we should keep [queue], remove [task]

Sorry I mis understood what needed to be changed and accidently also removed the [queue] section. Now it is clear.

@wxiaoguang wxiaoguang merged commit 86d4c8a into go-gitea:main Apr 18, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 18, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 18, 2024
@xor-gate @wxiaoguang @GiteaBot
Fixup app.example.ini for task section, which is now queue.task (go-g…
e3a5b7a 
…itea#30555)

Config section `[task]` has been deprecated in favor of `[queue.task]`

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot mentioned this pull request Apr 18, 2024
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 18, 2024
@xor-gate @wxiaoguang @GiteaBot
Fixup app.example.ini for task section, which is now queue.task (go-g…
197e470 
…itea#30555)

Config section `[task]` has been deprecated in favor of `[queue.task]`

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot mentioned this pull request Apr 18, 2024
Merged
@wxiaoguang
Copy link
Contributor

Made some changes, I think we should keep [queue], remove [task]

Sorry I mis understood what needed to be changed and accidently also removed the [queue] section. Now it is clear.

I realized that I didn't say it clearly before, the word this is quite ambiguous in that context 🤣 sorry for the confusing.

@xor-gate xor-gate deleted the setting_task_deprecated_app_example_ini branch April 18, 2024 11:24
silverwind pushed a commit that referenced this pull request Apr 18, 2024
@GiteaBot @xor-gate @wxiaoguang
Fixup app.example.ini for task section, which is now queue.task (#30555…
a05d098 
…) (#30562)

Backport #30555 by xor-gate

Config section `[task]` has been deprecated in favor of `[queue.task]`

Co-authored-by: Jerry Jacobs <xor-gate@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind pushed a commit that referenced this pull request Apr 18, 2024
@GiteaBot @xor-gate @wxiaoguang
Fixup app.example.ini for task section, which is now queue.task (#30555…
0184bd1 
…) (#30563)

Backport #30555 by xor-gate

Config section `[task]` has been deprecated in favor of `[queue.task]`

Co-authored-by: Jerry Jacobs <xor-gate@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 19, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f3b81c7 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Mock queue backoff duration (go-gitea#30553)
  Improve "Reference in new issue" modal (go-gitea#30547)
  Add a few root files to lint-spell (go-gitea#30530)
  Refactor and fix archive link bug (go-gitea#30535)
  Fixup app.example.ini for task section, which is now queue.task (go-gitea#30555)
  Some following up changes for routes (go-gitea#30550)
  Add form field id generation, remove duplicated ids (go-gitea#30546)
  Fix border-radius on view, blame and code search (go-gitea#30545)
  Disable enter key for accepting code completion in Monaco (go-gitea#30548)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@yardenshoham yardenshoham added the backport/done All backports for this PR have been created label May 3, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@xor-gate @wxiaoguang @lunny @yardenshoham @GiteaBot