Improve detecting empty files #31332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wxiaoguang
commented
Jun 12, 2024
wxiaoguang
commented
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
modifies/translation
modifies/go
wxiaoguang
added
the
type/refactoring
|
Thanks, will test with my 3 sample files. |
lunny
reviewed
Jun 12, 2024
lunny
approved these changes
Jun 12, 2024
GiteaBot
added
lgtm/need 1
|
Rendering looks good on all three sample files. I would prefer the placeholder text to be horizontally centered so that it can't be confused with actual content. |
|
Centered the text, works fine in plaintext as well as markup: 
There is different padding because of markdown parent class, but I guess this is a neglible issue. |
silverwind
approved these changes
Jun 12, 2024
GiteaBot
added
lgtm/done
pull-request-size
bot
added
size/M
|
padding, font-size and line-height fixed on the placeholder, so it looks exactly the same on markup vs. plaintext now: 
|
delvh
approved these changes
Jun 12, 2024
wxiaoguang
commented
Jun 13, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 13, 2024
* giteaofficial/main: Fixed incorrect localization `explorer.go` (go-gitea#31348) Improve detecting empty files (go-gitea#31332) Fix hash render end with colon (go-gitea#31319) Fix line number widths (go-gitea#31341) Fix navbar `+` menu flashing on page load (go-gitea#31281) Reduce memory usage for chunked artifact uploads to MinIO (go-gitea#31325) Fix dates displaying in a wrong manner when we're close to the end of the month (go-gitea#31331) Fix adopt repository has empty object name in database (go-gitea#31333) Optimize profile layout to enhance visual experience (go-gitea#31278)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.