From 61b8f0186dadf38f5d4be0f54149773a85e8790d Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Wed, 7 Aug 2019 17:25:48 +0200 Subject: [PATCH 01/10] fix commit statuses api url --- models/commit_status.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/commit_status.go b/models/commit_status.go index ecd319c5fecc..e864dc303667 100644 --- a/models/commit_status.go +++ b/models/commit_status.go @@ -89,7 +89,7 @@ func (status *CommitStatus) loadRepo(e Engine) (err error) { // APIURL returns the absolute APIURL to this commit-status. func (status *CommitStatus) APIURL() string { _ = status.loadRepo(x) - return fmt.Sprintf("%sapi/v1/%s/statuses/%s", + return fmt.Sprintf("%sapi/v1/repos/%s/statuses/%s", setting.AppURL, status.Repo.FullName(), status.SHA) } From bf69723817942d4be3b8ccbbff9416dd09fdc12c Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Wed, 7 Aug 2019 17:39:04 +0200 Subject: [PATCH 02/10] search refs before passing sha --- models/commit_status_test.go | 65 +++++++++++++++++++++++++++------- routers/api/v1/repo/git_ref.go | 13 ++++--- routers/api/v1/repo/status.go | 19 +++++++++- 3 files changed, 78 insertions(+), 19 deletions(-) diff --git a/models/commit_status_test.go b/models/commit_status_test.go index 580db127f6c5..012d4cef4acf 100644 --- a/models/commit_status_test.go +++ b/models/commit_status_test.go @@ -10,7 +10,7 @@ import ( "github.com/stretchr/testify/assert" ) -func TestGetCommitStatuses(t *testing.T) { +func TestGetCommitStatusesViaSHA(t *testing.T) { assert.NoError(t, PrepareTestDatabase()) repo1 := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository) @@ -20,20 +20,59 @@ func TestGetCommitStatuses(t *testing.T) { statuses, maxResults, err := GetCommitStatuses(repo1, sha1, &CommitStatusOptions{}) assert.NoError(t, err) assert.Equal(t, int(maxResults), 5) - if assert.Len(t, statuses, 5) { - assert.Equal(t, statuses[0].Context, "ci/awesomeness") - assert.Equal(t, statuses[0].State, CommitStatusPending) + assert.Len(t, statuses, 5) - assert.Equal(t, statuses[1].Context, "cov/awesomeness") - assert.Equal(t, statuses[1].State, CommitStatusWarning) + assert.Equal(t, statuses[0].Context, "ci/awesomeness") + assert.Equal(t, statuses[0].State, CommitStatusPending) + assert.Equal(t, statuses[0].APIURL(), "TODO") - assert.Equal(t, statuses[2].Context, "cov/awesomeness") - assert.Equal(t, statuses[2].State, CommitStatusSuccess) + assert.Equal(t, statuses[1].Context, "cov/awesomeness") + assert.Equal(t, statuses[1].State, CommitStatusWarning) + assert.Equal(t, statuses[1].APIURL(), "TODO") - assert.Equal(t, statuses[3].Context, "ci/awesomeness") - assert.Equal(t, statuses[3].State, CommitStatusFailure) + assert.Equal(t, statuses[2].Context, "cov/awesomeness") + assert.Equal(t, statuses[2].State, CommitStatusSuccess) + assert.Equal(t, statuses[2].APIURL(), "TODO") - assert.Equal(t, statuses[4].Context, "deploy/awesomeness") - assert.Equal(t, statuses[4].State, CommitStatusError) - } + assert.Equal(t, statuses[3].Context, "ci/awesomeness") + assert.Equal(t, statuses[3].State, CommitStatusFailure) + assert.Equal(t, statuses[3].APIURL(), "TODO") + + assert.Equal(t, statuses[4].Context, "deploy/awesomeness") + assert.Equal(t, statuses[4].State, CommitStatusError) + assert.Equal(t, statuses[4].APIURL(), "TODO") +} + +/* TODO +func TestGetCommitStatusesViaBranch(t *testing.T) { + assert.NoError(t, PrepareTestDatabase()) + + repo1 := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository) + + sha1 := "master" + statuses, maxResults, err := GetCommitStatuses(repo1, sha1, &CommitStatusOptions{}) + assert.NoError(t, err) + assert.Equal(t, int(maxResults), 5) + assert.Len(t, statuses, 5) + + assert.Equal(t, statuses[0].Context, "ci/awesomeness") + assert.Equal(t, statuses[0].State, CommitStatusPending) + assert.Equal(t, statuses[0].APIURL(), "TODO") + + assert.Equal(t, statuses[1].Context, "cov/awesomeness") + assert.Equal(t, statuses[1].State, CommitStatusWarning) + assert.Equal(t, statuses[1].APIURL(), "TODO") + + assert.Equal(t, statuses[2].Context, "cov/awesomeness") + assert.Equal(t, statuses[2].State, CommitStatusSuccess) + assert.Equal(t, statuses[2].APIURL(), "TODO") + + assert.Equal(t, statuses[3].Context, "ci/awesomeness") + assert.Equal(t, statuses[3].State, CommitStatusFailure) + assert.Equal(t, statuses[3].APIURL(), "TODO") + + assert.Equal(t, statuses[4].Context, "deploy/awesomeness") + assert.Equal(t, statuses[4].State, CommitStatusError) + assert.Equal(t, statuses[4].APIURL(), "TODO") } +*/ diff --git a/routers/api/v1/repo/git_ref.go b/routers/api/v1/repo/git_ref.go index e15f699a1dae..d7acc139f0d5 100644 --- a/routers/api/v1/repo/git_ref.go +++ b/routers/api/v1/repo/git_ref.go @@ -71,19 +71,22 @@ func GetGitRefs(ctx *context.APIContext) { getGitRefsInternal(ctx, ctx.Params("*")) } -func getGitRefsInternal(ctx *context.APIContext, filter string) { +func getGitRefs(ctx *context.APIContext, filter string) ([]*git.Reference, string, error) { gitRepo, err := git.OpenRepository(ctx.Repo.Repository.RepoPath()) if err != nil { - ctx.Error(500, "OpenRepository", err) - return + return nil, "OpenRepository", err } if len(filter) > 0 { filter = "refs/" + filter } - refs, err := gitRepo.GetRefsFiltered(filter) + return refs, "GetRefsFiltered", err +} + +func getGitRefsInternal(ctx *context.APIContext, filter string) { + refs, lastMethodName, err := getGitRefs(ctx, filter) if err != nil { - ctx.Error(500, "GetRefsFiltered", err) + ctx.Error(500, lastMethodName, err) return } diff --git a/routers/api/v1/repo/status.go b/routers/api/v1/repo/status.go index e4afb599eed9..3594f7e00ef0 100644 --- a/routers/api/v1/repo/status.go +++ b/routers/api/v1/repo/status.go @@ -155,7 +155,24 @@ func GetCommitStatusesByRef(ctx *context.APIContext) { // responses: // "200": // "$ref": "#/responses/StatusList" - getCommitStatuses(ctx, ctx.Params("ref")) + + filter := ctx.Params("ref") + sha := filter //By default and will be overridden if we found a good ref match + + refs, lastMethodName, err := getGitRefs(ctx, filter) + if err != nil { + ctx.Error(500, lastMethodName, err) + return + } + + if len(refs) > 0 { + c, err := refs[0].Commit() + if err == nil { + sha = c.ID.String() //Replace SHA with ref tag + } + } + + getCommitStatuses(ctx, sha) } func getCommitStatuses(ctx *context.APIContext, sha string) { From 7ede570459c2b245fd6a2285c1a8aecaa9f064ac Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Wed, 7 Aug 2019 17:54:28 +0200 Subject: [PATCH 03/10] adjust tests --- integrations/repo_commits_test.go | 23 +++++++++++ models/commit_status_test.go | 66 ++++++++----------------------- routers/api/v1/repo/status.go | 5 +-- 3 files changed, 40 insertions(+), 54 deletions(-) diff --git a/integrations/repo_commits_test.go b/integrations/repo_commits_test.go index 1f70d692519b..a83710b95255 100644 --- a/integrations/repo_commits_test.go +++ b/integrations/repo_commits_test.go @@ -5,7 +5,9 @@ package integrations import ( + "encoding/json" "net/http" + "net/http/httptest" "path" "testing" @@ -67,6 +69,27 @@ func doTestRepoCommitWithStatus(t *testing.T, state string, classes ...string) { for _, class := range classes { assert.True(t, sel.HasClass(class)) } + + //By SHA + req = NewRequest(t, "GET", "/api/v1/repos/user2/repo1/commits/"+path.Base(commitURL)+"/statuses") + testRepoCommitsWithStatus(t, session.MakeRequest(t, req, http.StatusOK), state) + //By Ref + req = NewRequest(t, "GET", "/api/v1/repos/user2/repo1/commits/heads%2Fmaster/statuses") + testRepoCommitsWithStatus(t, session.MakeRequest(t, req, http.StatusOK), state) +} + +func testRepoCommitsWithStatus(t *testing.T, resp *httptest.ResponseRecorder, state string) { + decoder := json.NewDecoder(resp.Body) + statuses := []*api.Status{} + assert.NoError(t, decoder.Decode(&statuses)) + assert.Len(t, statuses, 1) + for _, s := range statuses { + assert.Equal(t, api.StatusState(state), s.State) + assert.Equal(t, "http://localhost:3003/api/v1/repos/user2/repo1/statuses/65f1bf27bc3bf70f64657658635e66094edbcb4d", s.URL) + assert.Equal(t, "http://test.ci/", s.TargetURL) + assert.Equal(t, "", s.Description) + assert.Equal(t, "testci", s.Context) + } } func TestRepoCommitsWithStatusPending(t *testing.T) { diff --git a/models/commit_status_test.go b/models/commit_status_test.go index 012d4cef4acf..97783ae6f1a1 100644 --- a/models/commit_status_test.go +++ b/models/commit_status_test.go @@ -10,7 +10,7 @@ import ( "github.com/stretchr/testify/assert" ) -func TestGetCommitStatusesViaSHA(t *testing.T) { +func TestGetCommitStatuses(t *testing.T) { assert.NoError(t, PrepareTestDatabase()) repo1 := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository) @@ -22,57 +22,23 @@ func TestGetCommitStatusesViaSHA(t *testing.T) { assert.Equal(t, int(maxResults), 5) assert.Len(t, statuses, 5) - assert.Equal(t, statuses[0].Context, "ci/awesomeness") - assert.Equal(t, statuses[0].State, CommitStatusPending) - assert.Equal(t, statuses[0].APIURL(), "TODO") + assert.Equal(t, "ci/awesomeness", statuses[0].Context) + assert.Equal(t, CommitStatusPending, statuses[0].State) + assert.Equal(t, "https://try.gitea.io/api/v1/repos/user2/repo1/statuses/1234123412341234123412341234123412341234", statuses[0].APIURL()) - assert.Equal(t, statuses[1].Context, "cov/awesomeness") - assert.Equal(t, statuses[1].State, CommitStatusWarning) - assert.Equal(t, statuses[1].APIURL(), "TODO") + assert.Equal(t, "cov/awesomeness", statuses[1].Context) + assert.Equal(t, CommitStatusWarning, statuses[1].State) + assert.Equal(t, "https://try.gitea.io/api/v1/repos/user2/repo1/statuses/1234123412341234123412341234123412341234", statuses[1].APIURL()) - assert.Equal(t, statuses[2].Context, "cov/awesomeness") - assert.Equal(t, statuses[2].State, CommitStatusSuccess) - assert.Equal(t, statuses[2].APIURL(), "TODO") + assert.Equal(t, "cov/awesomeness", statuses[2].Context) + assert.Equal(t, CommitStatusSuccess, statuses[2].State) + assert.Equal(t, "https://try.gitea.io/api/v1/repos/user2/repo1/statuses/1234123412341234123412341234123412341234", statuses[2].APIURL()) - assert.Equal(t, statuses[3].Context, "ci/awesomeness") - assert.Equal(t, statuses[3].State, CommitStatusFailure) - assert.Equal(t, statuses[3].APIURL(), "TODO") + assert.Equal(t, "ci/awesomeness", statuses[3].Context) + assert.Equal(t, CommitStatusFailure, statuses[3].State) + assert.Equal(t, "https://try.gitea.io/api/v1/repos/user2/repo1/statuses/1234123412341234123412341234123412341234", statuses[3].APIURL()) - assert.Equal(t, statuses[4].Context, "deploy/awesomeness") - assert.Equal(t, statuses[4].State, CommitStatusError) - assert.Equal(t, statuses[4].APIURL(), "TODO") + assert.Equal(t, "deploy/awesomeness", statuses[4].Context) + assert.Equal(t, CommitStatusError, statuses[4].State) + assert.Equal(t, "https://try.gitea.io/api/v1/repos/user2/repo1/statuses/1234123412341234123412341234123412341234", statuses[4].APIURL()) } - -/* TODO -func TestGetCommitStatusesViaBranch(t *testing.T) { - assert.NoError(t, PrepareTestDatabase()) - - repo1 := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository) - - sha1 := "master" - statuses, maxResults, err := GetCommitStatuses(repo1, sha1, &CommitStatusOptions{}) - assert.NoError(t, err) - assert.Equal(t, int(maxResults), 5) - assert.Len(t, statuses, 5) - - assert.Equal(t, statuses[0].Context, "ci/awesomeness") - assert.Equal(t, statuses[0].State, CommitStatusPending) - assert.Equal(t, statuses[0].APIURL(), "TODO") - - assert.Equal(t, statuses[1].Context, "cov/awesomeness") - assert.Equal(t, statuses[1].State, CommitStatusWarning) - assert.Equal(t, statuses[1].APIURL(), "TODO") - - assert.Equal(t, statuses[2].Context, "cov/awesomeness") - assert.Equal(t, statuses[2].State, CommitStatusSuccess) - assert.Equal(t, statuses[2].APIURL(), "TODO") - - assert.Equal(t, statuses[3].Context, "ci/awesomeness") - assert.Equal(t, statuses[3].State, CommitStatusFailure) - assert.Equal(t, statuses[3].APIURL(), "TODO") - - assert.Equal(t, statuses[4].Context, "deploy/awesomeness") - assert.Equal(t, statuses[4].State, CommitStatusError) - assert.Equal(t, statuses[4].APIURL(), "TODO") -} -*/ diff --git a/routers/api/v1/repo/status.go b/routers/api/v1/repo/status.go index 3594f7e00ef0..9927ca0bf53e 100644 --- a/routers/api/v1/repo/status.go +++ b/routers/api/v1/repo/status.go @@ -166,10 +166,7 @@ func GetCommitStatusesByRef(ctx *context.APIContext) { } if len(refs) > 0 { - c, err := refs[0].Commit() - if err == nil { - sha = c.ID.String() //Replace SHA with ref tag - } + sha = refs[0].Object.String() //Replace SHA with ref id } getCommitStatuses(ctx, sha) From f457e2f4b583e71fbbc0a2b09638daee8b937d7f Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 8 Aug 2019 03:57:12 +0200 Subject: [PATCH 04/10] directly search tags and branches names + remove un-needed check in NewCommitStatus --- integrations/repo_commits_test.go | 4 +++- routers/api/v1/repo/status.go | 38 +++++++++++++++++++++++-------- 2 files changed, 32 insertions(+), 10 deletions(-) diff --git a/integrations/repo_commits_test.go b/integrations/repo_commits_test.go index a83710b95255..5f849808b2f3 100644 --- a/integrations/repo_commits_test.go +++ b/integrations/repo_commits_test.go @@ -74,7 +74,9 @@ func doTestRepoCommitWithStatus(t *testing.T, state string, classes ...string) { req = NewRequest(t, "GET", "/api/v1/repos/user2/repo1/commits/"+path.Base(commitURL)+"/statuses") testRepoCommitsWithStatus(t, session.MakeRequest(t, req, http.StatusOK), state) //By Ref - req = NewRequest(t, "GET", "/api/v1/repos/user2/repo1/commits/heads%2Fmaster/statuses") + req = NewRequest(t, "GET", "/api/v1/repos/user2/repo1/commits/master/statuses") + testRepoCommitsWithStatus(t, session.MakeRequest(t, req, http.StatusOK), state) + req = NewRequest(t, "GET", "/api/v1/repos/user2/repo1/commits/v1.1/statuses") testRepoCommitsWithStatus(t, session.MakeRequest(t, req, http.StatusOK), state) } diff --git a/routers/api/v1/repo/status.go b/routers/api/v1/repo/status.go index 9927ca0bf53e..409edb98537d 100644 --- a/routers/api/v1/repo/status.go +++ b/routers/api/v1/repo/status.go @@ -46,10 +46,7 @@ func NewCommitStatus(ctx *context.APIContext, form api.CreateStatusOption) { // "$ref": "#/responses/StatusList" sha := ctx.Params("sha") if len(sha) == 0 { - sha = ctx.Params("ref") - } - if len(sha) == 0 { - ctx.Error(400, "ref/sha not given", nil) + ctx.Error(400, "sha not given", nil) return } status := &models.CommitStatus{ @@ -157,21 +154,44 @@ func GetCommitStatusesByRef(ctx *context.APIContext) { // "$ref": "#/responses/StatusList" filter := ctx.Params("ref") - sha := filter //By default and will be overridden if we found a good ref match + if len(filter) == 0 { + ctx.Error(400, "ref not given", nil) + return + } - refs, lastMethodName, err := getGitRefs(ctx, filter) + refSHA, lastMethodName, err := searchRefCommit(ctx, "heads", filter) //Search branches if err != nil { ctx.Error(500, lastMethodName, err) return } + if refSHA != "" { + getCommitStatuses(ctx, refSHA) + return + } - if len(refs) > 0 { - sha = refs[0].Object.String() //Replace SHA with ref id + refSHA, lastMethodName, err = searchRefCommit(ctx, "tags", filter) //Search tags + if err != nil { + ctx.Error(500, lastMethodName, err) + return + } + if refSHA != "" { + getCommitStatuses(ctx, refSHA) + return } - getCommitStatuses(ctx, sha) + getCommitStatuses(ctx, filter) //By default filter is maybe the raw SHA } +func searchRefCommit(ctx *context.APIContext, refType, filter string) (string, string, error) { + refs, lastMethodName, err := getGitRefs(ctx, refType+"/"+filter) //Search branches + if err != nil { + return "", lastMethodName, err + } + if len(refs) > 0 { + return refs[0].Object.String(), "", nil //Return found SHA + } + return "", "", nil +} func getCommitStatuses(ctx *context.APIContext, sha string) { if len(sha) == 0 { ctx.Error(400, "ref/sha not given", nil) From 9f475d36017b0b5b35193d022598f8e42b904b70 Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 8 Aug 2019 03:57:50 +0200 Subject: [PATCH 05/10] fix comment --- routers/api/v1/repo/status.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/routers/api/v1/repo/status.go b/routers/api/v1/repo/status.go index 409edb98537d..aae5a372042b 100644 --- a/routers/api/v1/repo/status.go +++ b/routers/api/v1/repo/status.go @@ -183,7 +183,7 @@ func GetCommitStatusesByRef(ctx *context.APIContext) { } func searchRefCommit(ctx *context.APIContext, refType, filter string) (string, string, error) { - refs, lastMethodName, err := getGitRefs(ctx, refType+"/"+filter) //Search branches + refs, lastMethodName, err := getGitRefs(ctx, refType+"/"+filter) //Search by type if err != nil { return "", lastMethodName, err } From 6a573b4ae27d060ec7bb55177736db563dd53876 Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 8 Aug 2019 04:09:54 +0200 Subject: [PATCH 06/10] de-duplicate code --- routers/api/v1/repo/status.go | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/routers/api/v1/repo/status.go b/routers/api/v1/repo/status.go index aae5a372042b..806e298b6458 100644 --- a/routers/api/v1/repo/status.go +++ b/routers/api/v1/repo/status.go @@ -159,30 +159,23 @@ func GetCommitStatusesByRef(ctx *context.APIContext) { return } - refSHA, lastMethodName, err := searchRefCommit(ctx, "heads", filter) //Search branches - if err != nil { - ctx.Error(500, lastMethodName, err) - return - } - if refSHA != "" { - getCommitStatuses(ctx, refSHA) - return - } + for _, reftype := range []string{"heads", "tags"} { //Search branches and tags + refSHA, lastMethodName, err := searchRefCommitByType(ctx, reftype, filter) + if err != nil { + ctx.Error(500, lastMethodName, err) + return + } + if refSHA != "" { + getCommitStatuses(ctx, refSHA) + return + } - refSHA, lastMethodName, err = searchRefCommit(ctx, "tags", filter) //Search tags - if err != nil { - ctx.Error(500, lastMethodName, err) - return - } - if refSHA != "" { - getCommitStatuses(ctx, refSHA) - return } getCommitStatuses(ctx, filter) //By default filter is maybe the raw SHA } -func searchRefCommit(ctx *context.APIContext, refType, filter string) (string, string, error) { +func searchRefCommitByType(ctx *context.APIContext, refType, filter string) (string, string, error) { refs, lastMethodName, err := getGitRefs(ctx, refType+"/"+filter) //Search by type if err != nil { return "", lastMethodName, err From 29881db0673e22c871543d02f495382ea37577cb Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 8 Aug 2019 04:24:14 +0200 Subject: [PATCH 07/10] test: use relative setting.AppURL --- integrations/repo_commits_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/integrations/repo_commits_test.go b/integrations/repo_commits_test.go index 5f849808b2f3..7a4761adc64c 100644 --- a/integrations/repo_commits_test.go +++ b/integrations/repo_commits_test.go @@ -11,6 +11,7 @@ import ( "path" "testing" + "code.gitea.io/gitea/modules/setting" api "code.gitea.io/gitea/modules/structs" "github.com/stretchr/testify/assert" @@ -87,7 +88,7 @@ func testRepoCommitsWithStatus(t *testing.T, resp *httptest.ResponseRecorder, st assert.Len(t, statuses, 1) for _, s := range statuses { assert.Equal(t, api.StatusState(state), s.State) - assert.Equal(t, "http://localhost:3003/api/v1/repos/user2/repo1/statuses/65f1bf27bc3bf70f64657658635e66094edbcb4d", s.URL) + assert.Equal(t, setting.AppURL+"api/v1/repos/user2/repo1/statuses/65f1bf27bc3bf70f64657658635e66094edbcb4d", s.URL) assert.Equal(t, "http://test.ci/", s.TargetURL) assert.Equal(t, "", s.Description) assert.Equal(t, "testci", s.Context) From 81284829334cd7606ea9ba4d4bf62fe1b8ac6131 Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 8 Aug 2019 11:53:51 +0200 Subject: [PATCH 08/10] Update routers/api/v1/repo/status.go Co-Authored-By: Lauris BH --- routers/api/v1/repo/status.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/routers/api/v1/repo/status.go b/routers/api/v1/repo/status.go index 806e298b6458..8ca634f6a5db 100644 --- a/routers/api/v1/repo/status.go +++ b/routers/api/v1/repo/status.go @@ -166,7 +166,8 @@ func GetCommitStatusesByRef(ctx *context.APIContext) { return } if refSHA != "" { - getCommitStatuses(ctx, refSHA) + filter = refSHA + break return } From 31ee5710de4026dc59fa29238048fb2ba1682e38 Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 8 Aug 2019 11:55:14 +0200 Subject: [PATCH 09/10] remove return --- routers/api/v1/repo/status.go | 1 - 1 file changed, 1 deletion(-) diff --git a/routers/api/v1/repo/status.go b/routers/api/v1/repo/status.go index 8ca634f6a5db..f90522bed2cf 100644 --- a/routers/api/v1/repo/status.go +++ b/routers/api/v1/repo/status.go @@ -168,7 +168,6 @@ func GetCommitStatusesByRef(ctx *context.APIContext) { if refSHA != "" { filter = refSHA break - return } } From 5f4acca13fc9c7a574bf6d56f17404b1826ecb5d Mon Sep 17 00:00:00 2001 From: Antoine GIRARD Date: Thu, 8 Aug 2019 11:58:13 +0200 Subject: [PATCH 10/10] Update routers/api/v1/repo/status.go Co-Authored-By: Lauris BH --- routers/api/v1/repo/status.go | 1 + 1 file changed, 1 insertion(+) diff --git a/routers/api/v1/repo/status.go b/routers/api/v1/repo/status.go index f90522bed2cf..b3d16e79bc4d 100644 --- a/routers/api/v1/repo/status.go +++ b/routers/api/v1/repo/status.go @@ -185,6 +185,7 @@ func searchRefCommitByType(ctx *context.APIContext, refType, filter string) (str } return "", "", nil } + func getCommitStatuses(ctx *context.APIContext, sha string) { if len(sha) == 0 { ctx.Error(400, "ref/sha not given", nil)