Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple calls of http.ClientBefore() and http.ClientAfter() (for server as well) #477

Closed
gaplyk opened this issue Mar 3, 2017 · 3 comments · Fixed by #479
Closed

Allow multiple calls of http.ClientBefore() and http.ClientAfter() (for server as well) #477

gaplyk opened this issue Mar 3, 2017 · 3 comments · Fixed by #479

Comments

@gaplyk
Copy link
Contributor

gaplyk commented Mar 3, 2017

Right now we are limited to one last call to set Before and After handlers.
It would be good to have ability to call them multiple times.

Changes are small and won't affect anyone logic.
@peterbourgon
Copy link
Member

This already happens in server, I'm happy to take a PR for it to be the same way in client.

@basvanbeek
Copy link
Member

basvanbeek commented Mar 3, 2017 •
edited
Loading

already on that Peter :) as I'm working in transports anyway.

see #479

@gaplyk
Copy link
Contributor Author

gaplyk commented Mar 3, 2017

Awesome

@basvanbeek basvanbeek mentioned this issue Mar 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for gRPC Server Response Headers and Trailers, adding ClientAfter handler basvanbeek/kit
3 participants
@peterbourgon @gaplyk @basvanbeek