Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sd/etcd now requires Go 1.9 #612

Closed
peterbourgon opened this issue Sep 17, 2017 · 0 comments
Closed

sd/etcd now requires Go 1.9 #612

peterbourgon opened this issue Sep 17, 2017 · 0 comments
Assignees
Labels

Comments

@peterbourgon
Copy link
Member

peterbourgon commented Sep 17, 2017

sd/etcd imports github.com/coreos/etcd/client, which as of this commit 11 days ago now requires Go 1.9 due to the context and aliasing blah-blah-blah. Sigh.

I judge the contortions required to keep Go kit master building on anything other than the latest stable release not worth the effort, especially in the era of reasonable dependency management for downstream consumers i.e. dep. Thus I'll change the relevant CI systems to test on go1.9 and tip only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant