Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async (non-RPC) AMQP transport #841

Closed
madshov opened this issue Feb 27, 2019 · 7 comments
Closed

Async (non-RPC) AMQP transport #841

madshov opened this issue Feb 27, 2019 · 7 comments

Comments

@madshov
Copy link

madshov commented Feb 27, 2019

Hi All,

Any documentation/examples that exist around AMQP transport, subscriber/publisher?

Thanks

@madshov
Copy link
Author

madshov commented Feb 28, 2019

More specifically, I'm just interested in using RabbitMQ as a simple message broker. Receive a message and ACK it, if OK. I can see that the ServeDelivery() on the subscriber will respond to incoming messages, like RPC fashion. I'm not interested in the sending the response. Can I ignore it or could that cause any problems?

@peterbourgon
Copy link
Member

See previous discussion here. As I understand it, it would be possible to add an option to transport/amqp to not require a response, but it's not currently implemented.

@madshov
Copy link
Author

madshov commented Mar 1, 2019

Thanks Peter.
So if I understand you correctly, within go-kit, you are only considering AMQP transport if it does RPC?
If I want true one-way communication, it would be something I have to build on the side. That is, if I don't choose to send back an empty response with the EncodeNopResponse().

/mads

@peterbourgon
Copy link
Member

At the moment, yes. But it sounds like it would be relatively easy to enhance the AMQP package to not require a response.

@peterbourgon peterbourgon changed the title AMQP transport Async (non-RPC) AMQP transport Mar 4, 2019
@peterbourgon
Copy link
Member

I think #850 makes this fixed. If that's not the case, please re-open with details.

@fabiante
Copy link

@madshov I am interested in how you handled one-way communication. I'd like to implement a Go-based worker for a legacy system that uses RabbitMQ as a worker queue. In this scenario I also don't want to send a response.

Did you sucessfully implement this?

@madshov
Copy link
Author

madshov commented Sep 27, 2019

Hi @fabiante,
Yes I have successfully implemented @mattfung additions in go-kit v0.9.0 (i believe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants