Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read If-None-Match header if ETag is enabled in Static Handler #152

Closed
thehowl opened this issue Jan 20, 2018 · 2 comments · Fixed by #200
Closed

Read If-None-Match header if ETag is enabled in Static Handler #152

thehowl opened this issue Jan 20, 2018 · 2 comments · Fixed by #200
Labels
feature request

Comments

@thehowl
Copy link

thehowl commented Jan 20, 2018

At the moment, the If-None-Match header is ignored, whereas it should be checked to be the same as the ETag of the file being served by the static handler. Currently, the static content is always served, even when Macaron should close the connection with a 304 Not Modified response.

I've added this functionality to Gitea, in this PR. I'd be very glad to port it over to the official macaron repo, if Unknown is available to review & merge the PR :)
@thehowl thehowl mentioned this issue Jan 20, 2018
Closed
@unknwon
Copy link
Contributor

unknwon commented Mar 22, 2018

Hi, you can send a PR directly to this repository for review.

@humaidq humaidq mentioned this issue May 3, 2020
Merged
@unknwon
Copy link
Contributor

unknwon commented May 4, 2020

A new release is tagged upon resolving this issue: https://github.com/go-macaron/macaron/releases/tag/v1.3.8

Thanks to @humaidq!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

static: handle If-None-Match for ETag.
2 participants
@unknwon @thehowl