Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2 #153

Closed
ericchiang opened this issue Jul 9, 2024 · 4 comments
Closed

Release v2 #153

ericchiang opened this issue Jul 9, 2024 · 4 comments

Comments

@ericchiang
Copy link
Collaborator

v2 introduced some breaking changes to the API, so we need to tag a new major version.

Before doing so, I want to make sure that there are no additional API changes that are needed before doing that. Currently the only change is [24]byte to []byte. Are we sure we don't need anything else?

/cc @Quantu @joelferrier

@Quantu
Copy link
Contributor

Quantu commented Jul 9, 2024

This should be the only breaking change needed as far as I know. I have been using this myself for about a week now with v4.x, v5.4, and v5.7 yubikeys without issue. I do have a little new functionality I want to add that I'll have PRs for soon, but it doesn't affect current API calls.

@84adam
Copy link

84adam commented Jul 29, 2024

Any updates you can provide on this? Thank you!

@ericchiang
Copy link
Collaborator Author

Apologies for the delay here everyone. Life's been extremely busy

Thanks for the feedback that this is working! I've gone ahead and tagged v2.0.0 and promoted the v2 branch to default. I think that should fix this

@84adam
Copy link

84adam commented Aug 21, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants