fix: 'invalid memory address or nil pointer dereference' in response logger #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #872 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 14 14
Lines 1821 1821
=======================================
Hits 1751 1751
Misses 46 46
Partials 24 24 ☔ View full report in Codecov by Sentry. |
|
@matlockx I was able to make the release prep work on the browser. Now, v2.15.3 has been released. |
renovate bot
referenced
this pull request
in Michsior14/transmission-gluetun-port-update
Sep 26, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-resty/resty/v2](https://github.com/go-resty/resty) | `v2.15.2` -> `v2.15.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-resty/resty (github.com/go-resty/resty/v2)</summary> ### [`v2.15.3`](https://github.com/go-resty/resty/releases/tag/v2.15.3) [Compare Source](https://github.com/go-resty/resty/compare/v2.15.2...v2.15.3) ### Release Notes #### Bug Fixes - fix: 'invalid memory address or nil pointer dereference' in response logger by [@​matlockx](https://github.com/matlockx) in [https://github.com/go-resty/resty/pull/872](https://github.com/go-resty/resty/pull/872) #### Documentation - For release v2.15.3 by [@​jeevatkm](https://github.com/jeevatkm) in [https://github.com/go-resty/resty/pull/874](https://github.com/go-resty/resty/pull/874) #### New Contributors - [@​matlockx](https://github.com/matlockx) made their first contribution in [https://github.com/go-resty/resty/pull/872](https://github.com/go-resty/resty/pull/872) **Full Changelog**: go-resty/resty@v2.15.2...v2.15.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/Michsior14/transmission-gluetun-port-update). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jeevatkm
added a commit
that referenced
this pull request
Nov 2, 2024
…e in response logger (#872) Co-authored-by: Martin Jöhren <m.joehren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error like ‘dial tcp 10.66.0.229:80: connect: connection refused’ when request and response logging is activated causes an ‘invalid memory address or nil pointer dereference’. This is due to changes from version 2.14 to 2.15, where the logging call was moved up in the execute function. In version 2.14, the function returned early on this error, so the logging call was not made. Now, the logging call is made, and res.RawResponseProto is used without a nil check on RawResponse.
The fix is simple: use res.Proto(), which performs the nil check.
fixes #873