New release candidate: v1.5.5-rc.1 #637
Replies: 3 comments 5 replies
-
|
Thanks for keeping this project going. Awesome work. |
Beta Was this translation helpful? Give feedback.
-
|
When I updated my docker install, the update broke it so I couldn't login, giving an "sql: no rows in result set (500)" error. |
Beta Was this translation helpful? Give feedback.
-
|
From which version did you upgrade? Where do you have your shiori data folder? I updated my production shiori from 1.5.4 without issues. |
Beta Was this translation helpful? Give feedback.
-
|
from 1.5.4, i was just using the sqlite database with i think default settings. i got impatient and wiped the install after (was meaning to switch over to mysql anyways), so unfortunately i can't go back and figure out what caused it. if it doesn't happen for anyone else might have been a configuration error on my end (pretty new to self-hosting). i did run into a single bug for the ebook export, i'll do a proper bug report for that one in a bit. very excited to have a working ebook export, and it worked great for all but one archive. |
Beta Was this translation helpful? Give feedback.
-
|
How do you create the container? Did you delete it before the upgrade you say? I cant guarantee that no bugs are present, but upgrading should be non-destructive, since any database error stops the application from running before anything gets committed to disk. My upgrade path was the same as yours (same database as well). I plan to have proper install/upgrade instructions, along with a backup reminder as well. I hope you didnt lose many data. The other person I recall had a similar issue, his database was stored on a different path. #291 |
Beta Was this translation helpful? Give feedback.
-
|
The upgrade when I had the error was handled by watchtower, which should exactly recreate all the same settings as the prior install. I did lose all my bookmarks, slight bummer. I probably could have recovered them if I'd been patient enough to try and figure out what happened, so that's partially on me. Thinking about it, it could have just been because the database got wiped when the upgrade happened, if it was stored in the same directory, so that would probably be a configuration error on my end? I never figured out where the database was stored before. |
Beta Was this translation helpful? Give feedback.
-
|
Im not familiar with watchtower, but the only thing that comes to mind is that it didn't create a volume for the data shiori stores. Using an ephemeral volume would mean that any image upgrade (or container restart) would wipe the database. |
Beta Was this translation helpful? Give feedback.
-
|
Heads up: title is never retrieved // Make sure bookmark's title not empty
if book.Title == "" {
book.Title = book.URL
}
// ^ because if this
// …
bookmark, err := downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "")
// ^ it's always non-empty
// …
book, err = downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "")
// ^ it's always non-empty |
Beta Was this translation helpful? Give feedback.
-
Hello everyone!
I have cut a new release candidate with a few changes that had been on master for some time: v1.5.5-rc.1.
Feel free to download and try it out for a while, and if you experience any issues report them so we can fix those before the final release.
Huge thanks to all contributors!
Changes
Features
Fixes
Dependencies & CI
Beta Was this translation helpful? Give feedback.
All reactions