Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker doesn't compile correctly or build when pulling from master #263

Closed
symgryph opened this issue Aug 9, 2020 · 4 comments
Closed

Comments

@symgryph
Copy link

symgryph commented Aug 9, 2020

I tried using the dockerfile, system crashes with the following:

github.com/lib/pq/scram
github.com/go-shiori/shiori/internal/core
github.com/lib/pq
github.com/mattn/go-sqlite3
github.com/shurcooL/httpfs/vfsutil
github.com/shurcooL/vfsgen
github.com/go-shiori/shiori/internal/webserver
github.com/spf13/cobra
github.com/go-shiori/shiori/internal/cmd

github.com/go-shiori/shiori/internal/cmd

src/github.com/go-shiori/shiori/internal/cmd/root.go:93:32: too many arguments in call to gap.NewScope
have (gap.ScopeType, string, string)
want (gap.ScopeType, string)
src/github.com/go-shiori/shiori/internal/cmd/root.go:94:27: userScope.DataDir undefined (type *gap.Scope has no field or method DataDir)

@symgryph symgryph changed the title docker doesn't compile correctly or build wen pulling from master docker doesn't compile correctly or build when pulling from master Aug 9, 2020
@lapwat
Copy link
Contributor

lapwat commented Aug 11, 2020

This is because of this line:

userScope := apppaths.NewScope(apppaths.User, "shiori", "shiori")

The apppaths variable is of type Scope. This type was imported from https://github.com/muesli/go-app-paths

The NewScope signature has "recently" changed:

muesli/go-app-paths@549218f#diff-d44c7badbd1491a3c4c5bbaf9f55d173R39

@lapwat
Copy link
Contributor

lapwat commented Aug 11, 2020

Also, DataDir got replaced by DataDirs returning a prioritized list of data directories

See changelog here: https://github.com/muesli/go-app-paths/releases/tag/v0.2.0

@lapwat
Copy link
Contributor

lapwat commented Aug 11, 2020

Please accept the pull request: #264

@fmartingr
Copy link
Member

This is currently working (thanks for your PR) and we're planning changes in #278 and #341 as well. We will need a dependency update after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants