Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atomic wrappers for bool and error #612

Merged
merged 3 commits into from
Jun 10, 2017
Merged

Add atomic wrappers for bool and error #612

merged 3 commits into from
Jun 10, 2017

Conversation

julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented Jun 9, 2017 •
edited
Loading

Improves #608 by using re-usable wrappers for atomic booleans and also replaces mc.closedErr guarded by a lock with an atomic error field.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt added this to the v1.4 milestone Jun 9, 2017
@julienschmidt julienschmidt mentioned this pull request Jun 9, 2017
Merged
5 tasks
methane
methane approved these changes Jun 10, 2017
View reviewed changes
Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienschmidt julienschmidt merged commit 72e0ac3 into master Jun 10, 2017
@julienschmidt julienschmidt deleted the atomic branch June 10, 2017 18:02
@jsha jsha mentioned this pull request Nov 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@julienschmidt @methane