Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGSEGV on missing "version" attribute #1394

Closed
coffeemicha opened this issue Nov 9, 2023 · 1 comment
Closed

SIGSEGV on missing "version" attribute #1394

coffeemicha opened this issue Nov 9, 2023 · 1 comment
Labels
state: duplicate Duplicates another issue.

Comments

@coffeemicha
Copy link

  • Task version: v3.24.0
  • Operating system: Ubuntu (WSL)
  • Experiments enabled: No

When including a taskfile which does not have a "version" attribute set, a SIGSEGV is thrown

[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x617ba9]

goroutine 1 [running]:
github.com/Masterminds/semver/v3.(*Version).Compare(0xc000022f00?, 0x44?)
        github.com/Masterminds/semver/v3@v3.2.1/version.go:406 +0x29
github.com/go-task/task/v3/taskfile/read.Taskfile(0xc000203290)
        github.com/go-task/task/v3@v3.24.0/taskfile/read/taskfile.go:172 +0x1de

This should be handled gracefully

@task-bot task-bot added the state: needs triage Waiting to be triaged by a maintainer. label Nov 9, 2023
@pd93
Copy link
Member

pd93 commented Nov 10, 2023

Sounds like a duplicate of #1148.

This was fixed in #1149 and released in v3.25.0. Can you please try updating your task version and see if it resolves the issue?

@pd93 pd93 closed this as completed Nov 10, 2023
@pd93 pd93 added state: duplicate Duplicates another issue. and removed state: needs triage Waiting to be triaged by a maintainer. labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: duplicate Duplicates another issue.
Projects
None yet
Development

No branches or pull requests

3 participants