Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected logging of experiments usage #1805

Closed
rektdeckard opened this issue Sep 13, 2024 · 5 comments · Fixed by #1806
Closed

Unexpected logging of experiments usage #1805

rektdeckard opened this issue Sep 13, 2024 · 5 comments · Fixed by #1806
Assignees
Labels
area: formatting Changes related to output and formatting.

Comments

@rektdeckard
Copy link

I am using Task as an embedded runner in a larger CLI application, which is built on urfave/cli/v3. Whenever a help or Usage is printed in the app, I see the following text preceding my expected Usage text on stdout:

tobiasfried@slate livekit-cli % lk --help
Usage of experiments:
  -d, --dir string        Sets directory of execution.
  -t, --taskfile string   Choose which Taskfile to run. Defaults to "Taskfile.yml".
NAME:
  (expected help text)

This happens even when running completely unrelated actions that do not call into any task-related code, attempt to parse or run any taskfiles, etc.

  • Task version: 3.39.0
  • Operating system: macOS
  • Experiments enabled:
@task-bot task-bot added the state: needs triage Waiting to be triaged by a maintainer. label Sep 13, 2024
@rektdeckard
Copy link
Author

FWIW, I am not setting any TASK_X_ environment variables, nor using any experiments explicitly.

@rektdeckard
Copy link
Author

I believe that the initial program arguments are somehow being automatically consumed by Task, even when not asked to. The --help flag in my application is being ambiently consumed by some global initialization in Task.

@vmaerten
Copy link
Member

Hello!

Thanks for reporting! I'll take a look

@vmaerten vmaerten added type: bug Something not working as intended. area: formatting Changes related to output and formatting. and removed state: needs triage Waiting to be triaged by a maintainer. labels Sep 13, 2024
@vmaerten vmaerten linked a pull request Sep 13, 2024 that will close this issue
@rektdeckard
Copy link
Author

Appreciate it!

@vmaerten vmaerten self-assigned this Sep 13, 2024
@vmaerten
Copy link
Member

It'll be available in the next release.
You can test it by using the version from main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: formatting Changes related to output and formatting.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants